state: fix environment configuration watcher

state: fix environment configuration watcher



https://code.launchpad.net/~niemeyer/juju-core/fix-environs-watcher/+merge/125918

Requires: https://code.launchpad.net/~niemeyer/juju-core/resource-not-found/+merge/125917

(do not edit description out of merge proposal)

[niemeyer, 2012-09-24 03:54:02]

Please take a look.

[dave_cheney.net, 2012-09-24 05:35:35]

LGTM. Thank you.

https://codereview.appspot.com/6553063/diff/1/state/state_test.go
File state/state_test.go (right):

https://codereview.appspot.com/6553063/diff/1/state/state_test.go#newcode819
state/state_test.go:819: case <-time.After(5 * time.Second):
nit: 5 seconds is an eternity.

https://codereview.appspot.com/6553063/diff/1/state/watcher.go
File state/watcher.go (right):

https://codereview.appspot.com/6553063/diff/1/state/watcher.go#newcode1024
state/watcher.go:1024: out = w.out
very nice. Can you use a nil channel here, rather than the nul blocking channel.
The spec says that a send on a nil channel blocks forever.

[TheMue, 2012-09-24 10:59:45]

LGTM

[niemeyer, 2012-09-24 15:08:09]

*** Submitted:

state: fix environment configuration watcher

R=dfc, TheMue
CC=
https://codereview.appspot.com/6553063