Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(219)

Issue 6553059: code review 6553059: exp/inotify: cleanup ignored watch

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by mb0
Modified:
8 years, 7 months ago
Reviewers:
dfc, rsc
CC:
golang-dev
Visibility:
Public.

Description

exp/inotify: cleanup ignored watch inotify sends the IN_IGNORED event whenever a watch was removed. Fixes issue 2483

Patch Set 1 #

Patch Set 2 : diff -r bbb1a6dfcd58 https://code.google.com/p/go #

Patch Set 3 : diff -r bbb1a6dfcd58 https://code.google.com/p/go #

Total comments: 8

Patch Set 4 : diff -r fc6bbf557dac https://code.google.com/p/go #

Total comments: 1

Patch Set 5 : diff -r fc6bbf557dac https://code.google.com/p/go #

Total comments: 1

Patch Set 6 : diff -r 3836bcbafa69 https://code.google.com/p/go #

Total comments: 6

Patch Set 7 : diff -r 3836bcbafa69 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -8 lines) Patch
M src/pkg/exp/inotify/inotify_linux.go View 1 2 3 4 5 6 5 chunks +32 lines, -7 lines 0 comments Download
M src/pkg/exp/inotify/inotify_linux_test.go View 1 2 3 4 5 2 chunks +44 lines, -1 line 0 comments Download

Messages

Total messages: 14
mb0
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 10 months ago (2012-09-23 12:21:00 UTC) #1
dfc
On 2012/09/23 12:21:00, mb0 wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
9 years, 10 months ago (2012-09-28 02:16:25 UTC) #2
dfc
https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux.go File src/pkg/exp/inotify/inotify_linux.go (right): https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux.go#newcode200 src/pkg/exp/inotify/inotify_linux.go:200: if event.Mask&IN_IGNORED != 0 { ^ gofmt ? https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux_test.go ...
9 years, 10 months ago (2012-09-28 02:16:34 UTC) #3
mb0
http://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux.go File src/pkg/exp/inotify/inotify_linux.go (right): http://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux.go#newcode156 src/pkg/exp/inotify/inotify_linux.go:156: n, err := syscall.Read(w.fd, buf[0:]) ^ this will block ...
9 years, 10 months ago (2012-10-07 17:39:18 UTC) #4
rsc
https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux.go File src/pkg/exp/inotify/inotify_linux.go (right): https://codereview.appspot.com/6553059/diff/5001/src/pkg/exp/inotify/inotify_linux.go#newcode156 src/pkg/exp/inotify/inotify_linux.go:156: n, err := syscall.Read(w.fd, buf[0:]) If this only happens ...
9 years, 9 months ago (2012-11-01 18:46:05 UTC) #5
mb0
Hello golang-dev@googlegroups.com, dave@cheney.net, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-11-01 21:01:51 UTC) #6
rsc
seems plausible. anyone else? https://codereview.appspot.com/6553059/diff/14001/src/pkg/exp/inotify/inotify_linux.go File src/pkg/exp/inotify/inotify_linux.go (right): https://codereview.appspot.com/6553059/diff/14001/src/pkg/exp/inotify/inotify_linux.go#newcode88 src/pkg/exp/inotify/inotify_linux.go:88: w.AddWatch("/", IN_DELETE_SELF) // Add a ...
9 years, 9 months ago (2012-11-01 21:11:48 UTC) #7
mb0
Hello dave@cheney.net, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-11-01 21:21:53 UTC) #8
dfc
Sorry this took three months to be reviewed. Please <ping /> in the future. https://codereview.appspot.com/6553059/diff/15003/src/pkg/exp/inotify/inotify_linux.go ...
9 years, 5 months ago (2013-02-16 02:41:39 UTC) #9
dfc
================== WARNING: DATA RACE Read by goroutine 11: runtime.mapaccess2() /home/dfc/go/src/pkg/runtime/hashmap.c:944 +0x0 exp/inotify.(*Watcher).RemoveWatch() /home/dfc/go/src/pkg/exp/inotify/inotify_linux.go:142 +0x7d exp/inotify.TestInotifyIgnored() ...
9 years, 5 months ago (2013-02-16 02:45:41 UTC) #10
mb0
i pointed out the data race in the discussion mail 5 month ago. it was ...
9 years, 5 months ago (2013-02-16 11:56:24 UTC) #11
dfc
LGTM modulo these comments. https://codereview.appspot.com/6553059/diff/24001/src/pkg/exp/inotify/inotify_linux.go File src/pkg/exp/inotify/inotify_linux.go (right): https://codereview.appspot.com/6553059/diff/24001/src/pkg/exp/inotify/inotify_linux.go#newcode92 src/pkg/exp/inotify/inotify_linux.go:92: w.add("/", IN_DELETE_SELF) What about handling ...
9 years, 5 months ago (2013-02-17 00:54:53 UTC) #12
mb0
Hello dave@cheney.net, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 5 months ago (2013-02-17 01:25:56 UTC) #13
rsc
8 years, 7 months ago (2013-12-18 20:22:17 UTC) #14
R=close

code does not exist (here) anymore
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b