Issue 6552043: state: better errors for ReadSettings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6552043: state: better errors for ReadSettings

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by fwereade

Modified:
12 years, 6 months ago

Reviewers:
mp+125440

Visibility:
Public.

Description

state: better errors for ReadSettings It turns out there was a cleanly-separable test in old state that I failed to move over. Sorry. https://code.launchpad.net/~fwereade/juju-core/relation-unit-read-settings-errors/+merge/125440 Requires: https://code.launchpad.net/~fwereade/juju-core/almost-trivial-check-valid-names/+merge/125433 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: better errors for ReadSettings #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/relation.go	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	state/relation_test.go	View	1	1 chunk	+64 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

12 years, 6 months ago (2012-09-20 10:46:17 UTC) #3

*** Submitted:

state: better errors for ReadSettings

It turns out there was a cleanly-separable test in old state that I failed to
move over. Sorry.

R=niemeyer
CC=
https://codereview.appspot.com/6552043

Expand All Messages | Collapse All Messages