Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(688)

Issue 6551056: code review 6551056: [release-branch.go1] syscall: use exported StringToUTF1... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by adg
Modified:
11 years, 10 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

[release-branch.go1] syscall: use exported StringToUTF16 in windows test

Patch Set 1 #

Patch Set 2 : diff -r 6641287bf743 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/syscall/syscall_windows_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 10 months ago (2012-09-21 21:32:50 UTC) #1
rsc
LGTM Please double-check for me that the copy of StringToUTF16 in the release branch panics ...
11 years, 10 months ago (2012-09-21 22:03:02 UTC) #2
adg
On 21 September 2012 15:03, <rsc@golang.org> wrote: > LGTM > > Please double-check for me ...
11 years, 10 months ago (2012-09-21 22:05:25 UTC) #3
adg
Ah, it should have been StringToUTF16Ptr. Thank heavens for cross compilation. GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go ...
11 years, 10 months ago (2012-09-21 22:10:20 UTC) #4
adg
11 years, 10 months ago (2012-09-21 22:10:45 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=2d8bc3c94ecb ***

[release-branch.go1] syscall: use exported StringToUTF16 in windows test

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6551056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b