On 21 September 2012 15:03, <rsc@golang.org> wrote: > LGTM > > Please double-check for me ...
11 years, 2 months ago
(2012-09-21 22:05:25 UTC)
#3
On 21 September 2012 15:03, <rsc@golang.org> wrote:
> LGTM
>
> Please double-check for me that the copy of StringToUTF16 in the release
> branch panics if there are NULs in the string.
Yup
// StringToUTF16 returns the UTF-16 encoding of the UTF-8 string s.
// If s contains a NUL byte this function panics instead of
// returning an error.
func StringToUTF16(s string) []uint16 {
a, err := utf16FromString(s)
if err != nil {
panic("syscall: string with NUL passed to StringToUTF16")
}
return a
}
*** Submitted as http://code.google.com/p/go/source/detail?r=2d8bc3c94ecb *** [release-branch.go1] syscall: use exported StringToUTF16 in windows test R=golang-dev, rsc ...
11 years, 2 months ago
(2012-09-21 22:10:45 UTC)
#5
Issue 6551056: code review 6551056: [release-branch.go1] syscall: use exported StringToUTF1...
(Closed)
Created 11 years, 2 months ago by adg
Modified 11 years, 2 months ago
Reviewers:
Base URL:
Comments: 0