Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(41)

Issue 6551054: state: add better AssignUnit test

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by rog
Modified:
11 years, 7 months ago
Reviewers:
mp+125737
Visibility:
Public.

Description

state: add better AssignUnit test It passes, but at least that gives me more confidence that the test failures in trunk aren't due to a problem with AssignUnit. https://code.launchpad.net/~rogpeppe/juju-core/080-fix-assign-unit/+merge/125737 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: add better AssignUnit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -36 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M state/assign_test.go View 3 chunks +97 lines, -36 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
11 years, 7 months ago (2012-09-21 14:56:17 UTC) #1
niemeyer
LGTM
11 years, 7 months ago (2012-09-21 15:48:37 UTC) #2
rog
11 years, 7 months ago (2012-09-21 19:05:40 UTC) #3
*** Submitted:

state: add better AssignUnit test

It passes, but at least that gives me more confidence that the
test failures in trunk aren't due to a problem with AssignUnit.

R=niemeyer
CC=
https://codereview.appspot.com/6551054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b