Issue 6550052: state: change AssignUnit tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6550052: state: change AssignUnit tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rog

Modified:
11 years, 8 months ago

Reviewers:
mp+125669

Visibility:
Public.

Description

state: change AssignUnit tests Addressing comments from https://codereview.appspot.com/6549045 https://code.launchpad.net/~rogpeppe/juju-core/079-fix-assign-tests/+merge/125669 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: change AssignUnit tests #

Total comments: 4

Patch Set 3 : state: change AssignUnit tests #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -80 lines)			Patch
	A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	state/assign_test.go	View	1 2	16 chunks	+150 lines, -80 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

TheMue

LGTM, only one idea. https://codereview.appspot.com/6550052/diff/2001/state/assign_test.go File state/assign_test.go (right): https://codereview.appspot.com/6550052/diff/2001/state/assign_test.go#newcode343 state/assign_test.go:343: _, err := s.State.AddMachine() // ...

11 years, 8 months ago (2012-09-21 11:05:45 UTC) #2

niemeyer

https://codereview.appspot.com/6550052/diff/2001/state/assign_test.go File state/assign_test.go (right): https://codereview.appspot.com/6550052/diff/2001/state/assign_test.go#newcode180 state/assign_test.go:180: func (s *AssignSuite) TestAssignMachineWhenDying(c *C) { There are unhandled ...

11 years, 8 months ago (2012-09-21 12:55:55 UTC) #3

rog

11 years, 8 months ago (2012-09-21 13:08:08 UTC) #5

*** Submitted:

state: change AssignUnit tests

Addressing comments from https://codereview.appspot.com/6549045

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6550052

https://codereview.appspot.com/6550052/diff/2001/state/assign_test.go
File state/assign_test.go (right):

https://codereview.appspot.com/6550052/diff/2001/state/assign_test.go#newcode180
state/assign_test.go:180: func (s *AssignSuite) TestAssignMachineWhenDying(c *C)
{
On 2012/09/21 12:55:56, niemeyer wrote:
> There are unhandled comments for this function, I believe.

Done.

Expand All Messages | Collapse All Messages