Issue 6547044: .lbox: go vet on propose

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6547044: .lbox: go vet on propose (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 3 months ago by dfc

Modified:
5 years, 3 months ago

Reviewers:
mp+125432

Visibility:
Public.

Description

.lbox: go vet on propose Now lbox has the ability to do precommit hooks, we should do more of them. I've added a selective vet of the tree, with a few caviets. 1. 1.0.x vet sucks, so we skip the check unless you're using trunk 2. there is no way to identify go 1.1 version of vet, so we use 'devel' as the signal. Once go 1.1 is released, i'll update this check. https://code.launchpad.net/~dave-cheney/juju-core/108-lbox-go-vet/+merge/125432 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : .lbox: go vet on propose #

Total comments: 2

Patch Set 3 : .lbox: go vet on propose #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
M	.lbox.check	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/tools.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/service.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

That's great. One extra check, and LGTM. https://codereview.appspot.com/6547044/diff/3001/.lbox.check File .lbox.check (right): https://codereview.appspot.com/6547044/diff/3001/.lbox.check#newcode17 .lbox.check:17: -rangeloops \ ...

5 years, 3 months ago (2012-09-20 10:44:36 UTC) #3

dfc

5 years, 3 months ago (2012-09-20 11:33:36 UTC) #4

*** Submitted:

.lbox: go vet on propose

Now lbox has the ability to do precommit hooks, we should do more of them.
I've added a selective vet of the tree, with a few caviets. 

1. 1.0.x vet sucks, so we skip the check unless you're using trunk
2. there is no way to identify go 1.1 version of vet, so we use 'devel' as the
signal. Once go 1.1 is released, i'll update this check.

R=niemeyer
CC=
https://codereview.appspot.com/6547044

https://codereview.appspot.com/6547044/diff/3001/.lbox.check
File .lbox.check (right):

https://codereview.appspot.com/6547044/diff/3001/.lbox.check#newcode17
.lbox.check:17: -rangeloops \
On 2012/09/20 10:44:36, niemeyer wrote:
> -printfuncs ErrorContextf:1

Done.

Expand All Messages | Collapse All Messages