Issue 6546054: Make service contraints editable

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6546054: Make service contraints editable

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by thiago

Modified:
11 years, 7 months ago

Reviewers:
mp+125729, hazmat

Visibility:
Public.

Description

Make service contraints editable https://code.launchpad.net/~tveronezi/juju-ui/srv-constraints-edit-4/+merge/125729 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+312 lines, -237 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	app/store/env.js	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	app/templates/service-constraints.handlebars	View	1 chunk	+13 lines, -3 lines	0 comments	Download
M	app/views/service.js	View	2 chunks	+244 lines, -180 lines	0 comments	Download
M	lib/views/stylesheet.less	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	test/test_service_config_view.js	View	2 chunks	+38 lines, -52 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hazmat

11 years, 7 months ago (2012-09-21 14:53:57 UTC) #2

all of the comments from the previous merge proposal of this branch still apply.
in future pls stop renaming/manually versioning your branches and then
reproposing the same branch, which looses the previous merge proposal comments.
revisions are tracked by our vcs.

comments from previous branch.
https://codereview.appspot.com/6551048/

Expand All Messages | Collapse All Messages