Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(408)

Issue 6543066: code review 6543066: cmd/go, cmd/ld: fix libgcc order and add __image_base__... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by minux1
Modified:
9 years, 10 months ago
Reviewers:
CC:
brainman, rsc, golang-dev
Visibility:
Public.

Description

cmd/go, cmd/ld: fix libgcc order and add __image_base__ symbol for windows Fixes issue 4063.

Patch Set 1 #

Patch Set 2 : diff -r 7c53f5b1e1bf https://code.google.com/p/go #

Patch Set 3 : diff -r 7c53f5b1e1bf https://code.google.com/p/go #

Patch Set 4 : diff -r 7c53f5b1e1bf https://code.google.com/p/go #

Patch Set 5 : diff -r 7c53f5b1e1bf https://code.google.com/p/go #

Patch Set 6 : diff -r 99bb8c9e067d https://code.google.com/p/go #

Patch Set 7 : diff -r 28e51505db8a https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M src/cmd/go/build.go View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M src/cmd/ld/pe.c View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/run.bat View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5
minux1
Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 10 months ago (2012-09-24 11:58:04 UTC) #1
minux1
Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 10 months ago (2012-09-24 11:59:54 UTC) #2
rsc
LGTM but wait for Alex.
9 years, 10 months ago (2012-09-24 16:45:41 UTC) #3
brainman
LGTM for all I know about cgo :-) Thank you very much! Alex
9 years, 10 months ago (2012-09-26 01:26:52 UTC) #4
minux1
9 years, 10 months ago (2012-09-26 14:34:53 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=c9b56bb76d08 ***

cmd/go, cmd/ld: fix libgcc order and add __image_base__ symbol for windows
        Fixes issue 4063.

R=alex.brainman, rsc
CC=golang-dev
http://codereview.appspot.com/6543066
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b