Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1986)

Issue 6541047: fix environs/dummy compilation error (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by dave
Modified:
11 years, 7 months ago
Reviewers:
mp+125514
Visibility:
Public.

Description

fix environs/dummy compilation error adding state.Initialize broke environs/dummy, but if you look at the change, it is an improvement. https://code.launchpad.net/~dave-cheney/juju-core/109-environs-dummy-mstate-fix/+merge/125514 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : fix environs/dummy compilation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/dummy/environs.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
dave_cheney.net
Please take a look.
11 years, 7 months ago (2012-09-20 15:47:19 UTC) #1
niemeyer
LGTM
11 years, 7 months ago (2012-09-20 15:47:53 UTC) #2
aram
LGTM
11 years, 7 months ago (2012-09-20 15:47:56 UTC) #3
dave_cheney.net
11 years, 7 months ago (2012-09-20 15:49:06 UTC) #4
*** Submitted:

fix environs/dummy compilation error

adding state.Initialize broke environs/dummy, but if you look at the change, it
is an improvement.

R=aram
CC=
https://codereview.appspot.com/6541047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b