add Initialize

add Initialize

Prior to mstate, state.Initialize would accept a nil argument for the initial config, as this is non sensical this change makes this field manditory by changing it's type from map to *config.Config thereby enforcing a config which is at least valid to be present in the state.

Additionally, calling state.Initialize twice will not result the environment configuration being overwritten.

https://code.launchpad.net/~dave-cheney/juju-core/110-state-initialize/+merge/125500

(do not edit description out of merge proposal)

[dave_cheney.net, 2012-09-20 14:59:30]

Please take a look.

[dave_cheney.net, 2012-09-20 15:01:59]

Please take a look.

[niemeyer, 2012-09-20 15:25:55]

Neat. One minor:

https://codereview.appspot.com/6541045/diff/3001/state/open.go
File state/open.go (right):

https://codereview.appspot.com/6541045/diff/3001/state/open.go#newcode65
state/open.go:65: log.Printf("state: initializing state")
"storing no-secrets environment configuration"

Plus the if-env-exists-error behavior we talked about.

[dave_cheney.net, 2012-09-20 15:34:14]

Please take a look.

[niemeyer, 2012-09-20 15:36:59]

LGTM

[aram, 2012-09-20 15:37:46]

LGTM

https://codereview.appspot.com/6541045/diff/3002/state/open.go
File state/open.go (right):

https://codereview.appspot.com/6541045/diff/3002/state/open.go#newcode66
state/open.go:66: // state has already been initalised. If this is the case
s/initalised/initialized/

[dave_cheney.net, 2012-09-20 15:43:05]

*** Submitted:

add Initialize

Prior to mstate, state.Initialize would accept a nil argument for the initial
config, as this is non sensical this change makes this field manditory by
changing it's type from map to *config.Config thereby enforcing a config which
is at least valid to be present in the state.

Additionally, calling state.Initialize twice will not result the environment
configuration being overwritten.

R=niemeyer, aram
CC=
https://codereview.appspot.com/6541045