Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(562)

Issue 65400044: code review 65400044: unicode: upgrade to Unicode 6.3.0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by mpvl
Modified:
5 months, 2 weeks ago
Reviewers:
r, gobot, fundasecgin32
CC:
r, golang-codereviews
Visibility:
Public.

Description

unicode: upgrade to Unicode 6.3.0 This is a relatively minor change. This does not result in changes to go.text/unicode/norm. The go.text packages will therefore be relatively unaffected. It does make the way for an upgrade to CLDR 24, though. The tests of all.bash pass, as well as the tests in go.text after this update.

Patch Set 1 #

Patch Set 2 : diff -r 7f2863716967 https://code.google.com/p/go #

Patch Set 3 : diff -r 7f2863716967 https://code.google.com/p/go #

Patch Set 4 : diff -r 7f2863716967 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -32 lines) Patch
M src/pkg/bufio/scan.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/fmt/scan.go View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/regexp/syntax/parse_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/unicode/maketables.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/unicode/script_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/unicode/tables.go View 1 24 chunks +35 lines, -26 lines 0 comments Download

Messages

Total messages: 6
mpvl
Hello r@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 10 months ago (2014-02-18 14:34:55 UTC) #1
r
LGTM that mongolian vowel separator, eh?
10 years, 10 months ago (2014-02-18 16:04:19 UTC) #2
mpvl
Apparently the consortium decided that it is not separating mongolian vowels enough to be considered ...
10 years, 10 months ago (2014-02-18 19:05:04 UTC) #3
mpvl
*** Submitted as https://code.google.com/p/go/source/detail?r=2c8e3c799610 *** unicode: upgrade to Unicode 6.3.0 This is a relatively minor ...
10 years, 10 months ago (2014-02-18 19:13:08 UTC) #4
gobot
This CL appears to have broken the darwin-386-cheney builder.
10 years, 10 months ago (2014-02-18 19:17:01 UTC) #5
fundasecgin32
5 months, 2 weeks ago (2024-07-11 11:33:19 UTC) #6
Message was sent while issue was closed.

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b