Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2662)

Issue 6535054: AdSense Host API v4.1 PHP sample code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by sgomes_google
Modified:
11 years, 7 months ago
Reviewers:
chirags
Base URL:
http://google-api-php-client.googlecode.com/svn/trunk/examples/adsensehost/
Visibility:
Public.

Description

AdSense Host API v4.1 PHP sample code

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updating samples to match changes to client lib namespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1133 lines, -515 lines) Patch
D examples/adsensehost/AdSenseAuth.php View 1 1 chunk +0 lines, -132 lines 0 comments Download
A examples/adsensehost/AdSenseHostAuth.php View 1 1 chunk +133 lines, -0 lines 0 comments Download
M examples/adsensehost/BaseExample.php View 1 3 chunks +16 lines, -7 lines 0 comments Download
A examples/adsensehost/examples/AddAdUnitToPublisher.php View 1 1 chunk +73 lines, -0 lines 0 comments Download
A examples/adsensehost/examples/AddCustomChannelToHost.php View 1 1 chunk +47 lines, -0 lines 0 comments Download
A examples/adsensehost/examples/AddUrlChannelToHost.php View 1 1 chunk +45 lines, -0 lines 0 comments Download
A examples/adsensehost/examples/DeleteAdUnitOnPublisher.php View 1 1 chunk +48 lines, -0 lines 0 comments Download
A examples/adsensehost/examples/DeleteCustomChannelOnHost.php View 1 1 chunk +46 lines, -0 lines 0 comments Download
A examples/adsensehost/examples/DeleteUrlChannelOnHost.php View 1 1 chunk +46 lines, -0 lines 0 comments Download
D examples/adsensehost/examples/GenerateReport.php View 1 1 chunk +0 lines, -57 lines 0 comments Download
A examples/adsensehost/examples/GenerateReportForHost.php View 1 1 chunk +55 lines, -0 lines 0 comments Download
A examples/adsensehost/examples/GenerateReportForPublisher.php View 1 1 chunk +59 lines, -0 lines 0 comments Download
D examples/adsensehost/examples/GenerateReportWithPaging.php View 1 1 chunk +0 lines, -79 lines 0 comments Download
A examples/adsensehost/examples/GetAccountDataForExistingPublisher.php View 1 1 chunk +55 lines, -0 lines 0 comments Download
D examples/adsensehost/examples/GetAllAdClients.php View 1 1 chunk +0 lines, -59 lines 0 comments Download
A examples/adsensehost/examples/GetAllAdClientsForHost.php View 1 1 chunk +59 lines, -0 lines 0 comments Download
A examples/adsensehost/examples/GetAllAdClientsForPublisher.php View 1 1 chunk +62 lines, -0 lines 0 comments Download
A examples/adsensehost/examples/GetAllAdUnitsForPublisher.php View 1 1 chunk +60 lines, -0 lines 0 comments Download
D examples/adsensehost/examples/GetAllCustomChannels.php View 1 1 chunk +0 lines, -58 lines 0 comments Download
A examples/adsensehost/examples/GetAllCustomChannelsForHost.php View 1 1 chunk +61 lines, -0 lines 0 comments Download
D examples/adsensehost/examples/GetAllUrlChannels.php View 1 1 chunk +0 lines, -57 lines 0 comments Download
A examples/adsensehost/examples/GetAllUrlChannelsForHost.php View 1 1 chunk +59 lines, -0 lines 0 comments Download
A examples/adsensehost/examples/StartAssociationSession.php View 1 1 chunk +40 lines, -0 lines 0 comments Download
A examples/adsensehost/examples/UpdateAdUnitOnPublisher.php View 1 1 chunk +57 lines, -0 lines 0 comments Download
A examples/adsensehost/examples/UpdateCustomChannelOnHost.php View 1 1 chunk +52 lines, -0 lines 0 comments Download
A examples/adsensehost/examples/VerifyAssociationSession.php View 1 1 chunk +43 lines, -0 lines 0 comments Download
M examples/adsensehost/htmlHelper.php View 1 3 chunks +3 lines, -57 lines 0 comments Download
M examples/adsensehost/index.php View 1 5 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 8
sgomes_google
11 years, 7 months ago (2012-09-19 16:50:18 UTC) #1
chirags
LGTM! The generated classes should now be prefixed with Google_. Let me know if you ...
11 years, 7 months ago (2012-09-19 17:12:12 UTC) #2
sgomes_google
Thanks, Chirag! Could you perhaps generate Google_AdsensehostService.php for me, so that I can use a ...
11 years, 7 months ago (2012-09-19 17:28:15 UTC) #3
chirags
I just published the latest version of contrib/Google_AdsenseService.php and contrib/Google_AdsensehostService.php. Available on TRUNK as of ...
11 years, 7 months ago (2012-09-19 17:39:53 UTC) #4
sgomes_google
11 years, 7 months ago (2012-09-20 13:24:35 UTC) #5
sgomes_google
Fixed everything to match new namespaces/class names. https://codereview.appspot.com/6535054/diff/1/examples/AddAdUnitToPublisher.php File examples/AddAdUnitToPublisher.php (right): https://codereview.appspot.com/6535054/diff/1/examples/AddAdUnitToPublisher.php#newcode35 examples/AddAdUnitToPublisher.php:35: $adUnit = ...
11 years, 7 months ago (2012-09-20 13:28:08 UTC) #6
sgomes_google
Hey Chirag, Do the latest changes look good? I'd like to get this into the ...
11 years, 7 months ago (2012-09-25 11:13:21 UTC) #7
chirags
11 years, 7 months ago (2012-09-25 21:52:28 UTC) #8
LGTM. Thank you!

Also, you should have commit access to the PHP client.

On 2012/09/25 11:13:21, sgomes_google wrote:
> Hey Chirag,
> 
> Do the latest changes look good? I'd like to get this into the repository as
> soon as possible.
> 
> Thanks!
> 
> --Sérgio
> 
> ---
> On 2012/09/20 13:28:08, sgomes_google wrote:
> > Fixed everything to match new namespaces/class names.
> > 
> >
>
https://codereview.appspot.com/6535054/diff/1/examples/AddAdUnitToPublisher.php
> > File examples/AddAdUnitToPublisher.php (right):
> > 
> >
>
https://codereview.appspot.com/6535054/diff/1/examples/AddAdUnitToPublisher.p...
> > examples/AddAdUnitToPublisher.php:35: $adUnit = new AdUnit();
> > On 2012/09/19 17:12:13, chirags wrote:
> > > Should this be Google_AdUnit?
> > 
> > Done.
> > 
> >
>
https://codereview.appspot.com/6535054/diff/1/examples/AddCustomChannelToHost...
> > File examples/AddCustomChannelToHost.php (right):
> > 
> >
>
https://codereview.appspot.com/6535054/diff/1/examples/AddCustomChannelToHost...
> > examples/AddCustomChannelToHost.php:33: $customChannel = new
CustomChannel();
> > On 2012/09/19 17:12:13, chirags wrote:
> > > This should be Google_CustomChannel
> > 
> > Done.
> > 
> >
>
https://codereview.appspot.com/6535054/diff/1/examples/UpdateAdUnitOnPublishe...
> > File examples/UpdateAdUnitOnPublisher.php (right):
> > 
> >
>
https://codereview.appspot.com/6535054/diff/1/examples/UpdateAdUnitOnPublishe...
> > examples/UpdateAdUnitOnPublisher.php:41: $contentAdsSettings = new
> > AdUnitContentAdsSettings();
> > On 2012/09/19 17:12:13, chirags wrote:
> > > Google_AdUnitContentAdsSettings
> > 
> > Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b