clean up lxc process management

clean up lxc process management

Adopted from ben's branch of the same name. Ensure better killing of processes 
on destroy env, and additionally expand scope to all services utilized by local 
env (ie file-server was still using upstart). Also ensures compatibility with 
dev branches since py path was previously being stripped.

https://code.launchpad.net/~hazmat/juju/lxc-killpid/+merge/125333

(do not edit description out of merge proposal)

[hazmat, 2012-09-19 20:35:15]

Please take a look.

[SpamapS, 2012-09-20 00:10:39]

All in all, looks pretty good. Just a few minor questions and cleanups. This
also addresses this bug:

https://bugs.launchpad.net/juju/+bug/1027537

Which is the only open bug in juju for Debian.

https://codereview.appspot.com/6533057/diff/1/juju/lib/tests/test_service.py
File juju/lib/tests/test_service.py (right):

https://codereview.appspot.com/6533057/diff/1/juju/lib/tests/test_service.py#...
juju/lib/tests/test_service.py:91: 
I get why this is here, but it seems like we're asking for this to turn into an
unreliable test. Wouldn't os.wait make more sense?

https://codereview.appspot.com/6533057/diff/1/juju/providers/local/tests/test...
File juju/providers/local/tests/test_agent.py (right):

https://codereview.appspot.com/6533057/diff/1/juju/providers/local/tests/test...
juju/providers/local/tests/test_agent.py:21: #print "intercept", args, kwargs
This, and the other commented out assertEquals appear to be accidental.

https://codereview.appspot.com/6533057/diff/1/juju/providers/local/tests/test...
juju/providers/local/tests/test_agent.py:67: #self.addCleanup(cleanup_root_file,
juju_directory)
And this one

https://codereview.appspot.com/6533057/diff/1/juju/providers/local/tests/test...
File juju/providers/local/tests/test_files.py (right):

https://codereview.appspot.com/6533057/diff/1/juju/providers/local/tests/test...
juju/providers/local/tests/test_files.py:47: def xtest_upstart(self):
Any reason we're not just getting rid of this? I don't see the upstart specific
code coming back to the local provider any time soon. If anything, it will go in
juju.lib so both local and non-local agents can use it.