Move expose button to well

Move expose button to well



https://code.launchpad.net/~tveronezi/juju-ui/move-expose-button/+merge/125298

Requires: https://code.launchpad.net/~tveronezi/juju-ui/my-ui/+merge/125054

(do not edit description out of merge proposal)

[thiago, 2012-09-19 18:43:42]

Please take a look.

[thiago, 2012-09-19 18:56:20]

Moving the expose button to "well"

https://codereview.appspot.com/6533055/diff/1/app/templates/overview.handlebars
File app/templates/overview.handlebars (right):

https://codereview.appspot.com/6533055/diff/1/app/templates/overview.handleba...
app/templates/overview.handlebars:7: <button id="zoom-in-btn">+</button>
This is extra code from trunk. It is not part of the changes I did for this
task.

https://codereview.appspot.com/6533055/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6533055/diff/1/app/views/environment.js#newcode1
app/views/environment.js:1: 'use strict';
This is extra code from trunk. It is not part of the changes I did for this
task. Please ignore these changes.

https://codereview.appspot.com/6533055/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6533055/diff/1/lib/views/stylesheet.less#newcode1
lib/views/stylesheet.less:1: /* Processed with LESS from
lib/views/stylesheet.less */
This is extra code from trunk. It is not part of the changes I did for this
task. Please ignore these changes.

https://codereview.appspot.com/6533055/diff/1/test/test_environment_view.js
File test/test_environment_view.js (right):

https://codereview.appspot.com/6533055/diff/1/test/test_environment_view.js#n...
test/test_environment_view.js:1: 'use strict';
This is extra code from trunk. It is not part of the changes I did for this
task. Please ignore these changes.

https://codereview.appspot.com/6533055/diff/1/test/test_service_config_view.js
File test/test_service_config_view.js (right):

https://codereview.appspot.com/6533055/diff/1/test/test_service_config_view.j...
test/test_service_config_view.js:1: 'use strict';
This is extra code from trunk. It is not part of the changes I did for this
task. Please ignore these changes.

[hazmat, 2012-09-19 19:56:29]

https://codereview.appspot.com/6533055/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/6533055/diff/1/app/app.js#newcode210
app/app.js:210: service: service,
s/service/model .. we want the generic name so views bound to models can use
base class support for binding later.

https://codereview.appspot.com/6533055/diff/1/app/templates/overview.handlebars
File app/templates/overview.handlebars (right):

https://codereview.appspot.com/6533055/diff/1/app/templates/overview.handleba...
app/templates/overview.handlebars:7: <button id="zoom-in-btn">+</button>
On 2012/09/19 18:56:20, thiago wrote:
> This is extra code from trunk. It is not part of the changes I did for this
> task.

its here because your pre-requisite didn't merge trunk.

https://codereview.appspot.com/6533055/diff/1/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/6533055/diff/1/app/views/service.js#newcode54
app/views/service.js:54: Y.mix(this, exposeButtonMixin, undefined, undefined,
undefined, true);
the mix should be done at definition scope instead of initialization. i'd
suggest instead creating a BaseServiceView that inherits JujUBaseView, with
these methods, and then using that for the inheritance structure of the other
service views instead of JujuBaseView

[benji, 2012-09-19 20:32:37]

The requested changes (the ones that are possible) are going to be in the
roll-up branch.

https://codereview.appspot.com/6533055/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/6533055/diff/1/app/app.js#newcode210
app/app.js:210: service: service,
On 2012/09/19 19:56:29, hazmat wrote:
> s/service/model .. we want the generic name so views bound to models can use
> base class support for binding later.

We are fixing this in a "roll-up" branch.

https://codereview.appspot.com/6533055/diff/1/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/6533055/diff/1/app/views/service.js#newcode54
app/views/service.js:54: Y.mix(this, exposeButtonMixin, undefined, undefined,
undefined, true);
On 2012/09/19 19:56:29, hazmat wrote:
> the mix should be done at definition scope instead of initialization.

That won't work because in the definition scope ServiceRelations is a function
instead of an object.

> i'd
> suggest instead creating a BaseServiceView that inherits JujUBaseView, with
> these methods, and then using that for the inheritance structure of the other
> service views instead of JujuBaseView

That doesn't quite work either.  We settled on this approach was suggested by
Ben.