Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(658)

Issue 6533044: Add RelationUnit.EnsureJoin, .EnsureDepart

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by fwereade
Modified:
11 years, 7 months ago
Reviewers:
mp+124886
Visibility:
Public.

Description

Add RelationUnit.EnsureJoin, .EnsureDepart ...in preparation for the mstate implementation which will separate potential unit presence from actual unit presence. https://code.launchpad.net/~fwereade/juju-core/relation-unit-mstate-prep/+merge/124886 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add RelationUnit.EnsureJoin, .EnsureDepart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -26 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujuc/server/context_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M cmd/jujuc/server/util_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M state/relation.go View 1 2 chunks +12 lines, -2 lines 0 comments Download
M state/relation_test.go View 1 17 chunks +17 lines, -17 lines 0 comments Download
M worker/uniter/relationer.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M worker/uniter/relationer_test.go View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
fwereade
Please take a look.
11 years, 7 months ago (2012-09-18 10:56:18 UTC) #1
niemeyer
LGTM
11 years, 7 months ago (2012-09-18 11:13:37 UTC) #2
fwereade
11 years, 7 months ago (2012-09-18 11:39:52 UTC) #3
*** Submitted:

Add RelationUnit.EnsureJoin, .EnsureDepart

...in preparation for the mstate implementation which will separate potential
unit presence from actual unit presence.

R=niemeyer
CC=
https://codereview.appspot.com/6533044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b