Issue 65330043: PS UI fix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 65330043: PS UI fix

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by prannoysircar0325

Modified:
10 years, 7 months ago

Reviewers:
mail2coolgarg

Base URL:
https://bhusan.unfuddle.com/svn/bhusan_axisrooms/

Visibility:
Public.

More Reviews

Description

PS UI fix

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+285 lines, -96 lines)			Patch
M	arsupplier/res/drawable/gridshape.xml	View	1 chunk	+12 lines, -15 lines	0 comments	Download
M	arsupplier/res/drawable/leftarrow.png	View	Binary file		0 comments	Download
M	arsupplier/res/drawable/rightarrow.png	View	Binary file		0 comments	Download
M	arsupplier/res/drawable/roundshape.xml	View	1 chunk	+12 lines, -12 lines	0 comments	Download
A	arsupplier/res/drawable/shape_inventory.xml	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	arsupplier/res/drawable/shape_inventory_grid.xml	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	arsupplier/res/drawable/shape_inventory_hotel_selection.xml	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	arsupplier/res/drawable/shape_update_inventory_.xml	View	1 chunk	+14 lines, -0 lines	0 comments	Download
A	arsupplier/res/layout/action_bar_inventory.xml	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	arsupplier/res/layout/action_bar_option_menu.xml	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	arsupplier/res/layout/action_bar_select_inventory.xml	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	arsupplier/res/layout/action_bar_update_inventory.xml	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	arsupplier/res/layout/activity_main.xml	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	arsupplier/res/layout/calendar_gridcell.xml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	arsupplier/res/layout/calenderview.xml	View	3 chunks	+34 lines, -17 lines	0 comments	Download
M	arsupplier/res/layout/inventory.xml	View	1 chunk	+17 lines, -7 lines	0 comments	Download
M	arsupplier/res/layout/updateinventory.xml	View	3 chunks	+39 lines, -38 lines	0 comments	Download
M	arsupplier/res/values/colors.xml	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	arsupplier/src/app/axisrooms/OptionMenuActivity.java	View	3 chunks	+4 lines, -2 lines	1 comment	Download
M	arsupplier/src/app/axisrooms/inventory/CalenderActivity.java	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	arsupplier/src/app/axisrooms/inventory/InventoryMenuActivity.java	View	3 chunks	+5 lines, -2 lines	0 comments	Download
M	arsupplier/src/app/axisrooms/inventory/UpdateInventoryActivity.java	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

mail2coolgarg

10 years, 7 months ago (2014-02-18 15:06:55 UTC) #2

looks good
commit.

https://codereview.appspot.com/65330043/diff/1/arsupplier/src/app/axisrooms/O...
File arsupplier/src/app/axisrooms/OptionMenuActivity.java (right):

https://codereview.appspot.com/65330043/diff/1/arsupplier/src/app/axisrooms/O...
arsupplier/src/app/axisrooms/OptionMenuActivity.java:64:
callIntent.setData(Uri.parse("tel:9900601023"));
read phone from strings.xml

Expand All Messages | Collapse All Messages