Issue 6532047: cmd: FileVar, fix comments, fix test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6532047: cmd: FileVar, fix comments, fix test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by dave

Modified:
11 years, 7 months ago

Reviewers:
mp+124949

Visibility:
Public.

Description

cmd: FileVar, fix comments, fix test Sorry, getting tired, it's one am at the moment. https://code.launchpad.net/~dave-cheney/juju-core/105-cmd-juju-filevar-fix-comments/+merge/124949 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd: FileVar, fix comments, fix test #

Patch Set 3 : cmd: FileVar, fix comments, fix test #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/filevar.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	cmd/juju/cmd_test.go	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

Thanks, sorry about the breakage. On Wed, Sep 19, 2012 at 3:54 AM, <n13m3y3r@gmail.com> wrote: ...

11 years, 7 months ago (2012-09-18 20:36:26 UTC) #4

dave_cheney.net

11 years, 7 months ago (2012-09-18 20:42:18 UTC) #5

*** Submitted:

cmd: FileVar, fix comments, fix test

Sorry, getting tired, it's one am at the moment.

R=niemeyer
CC=
https://codereview.appspot.com/6532047

Expand All Messages | Collapse All Messages