cmd/juju: set: add --config path

cmd/juju: set: add --config path

Checkpoint branch: Add --config path option. Option value parsing is complicated, and comming up next.

https://code.launchpad.net/~dave-cheney/juju-core/101-cmd-juju-config-set-config-filevar/+merge/124879

(do not edit description out of merge proposal)

[dfc, 2012-09-18 10:26:49]

Please take a look.

[fwereade, 2012-09-18 10:37:36]

Re following comment: we can't make relative paths work right unless we EITHER
defer opening the file until Run time (at which point we know the working dir)
OR rearrange cmd such that the Context is available to the command at Init time.
I'd favour the first option myself, mainly just because I'd expect the second
option to be disproportionately disruptive considering the benefit.

https://codereview.appspot.com/6532043/diff/1/cmd/juju/cmd_test.go
File cmd/juju/cmd_test.go (right):

https://codereview.appspot.com/6532043/diff/1/cmd/juju/cmd_test.go#newcode350
cmd/juju/cmd_test.go:350: c.Assert(com.Config.ReadCloser, NotNil)
Need a test for relative path.

[dfc, 2012-09-18 12:50:34]

On 2012/09/18 10:37:36, fwereade wrote:
> Re following comment: we can't make relative paths work right unless we EITHER
> defer opening the file until Run time (at which point we know the working dir)
> OR rearrange cmd such that the Context is available to the command at Init
time.
> I'd favour the first option myself, mainly just because I'd expect the second
> option to be disproportionately disruptive considering the benefit.
> 
> https://codereview.appspot.com/6532043/diff/1/cmd/juju/cmd_test.go
> File cmd/juju/cmd_test.go (right):
> 
> https://codereview.appspot.com/6532043/diff/1/cmd/juju/cmd_test.go#newcode350
> cmd/juju/cmd_test.go:350: c.Assert(com.Config.ReadCloser, NotNil)
> Need a test for relative path.

https://codereview.appspot.com/6532045

[dfc, 2012-09-19 09:23:36]

Please take a look.

[fwereade, 2012-09-19 10:13:04]

LGTM

[dfc, 2012-09-19 10:37:16]

*** Submitted:

cmd/juju: set: add --config path

Checkpoint branch: Add --config path option. Option value parsing is
complicated, and comming up next.

R=fwereade
CC=
https://codereview.appspot.com/6532043