Issue 6528046: Implement expose button

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6528046: Implement expose button

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by thiago

Modified:
11 years, 7 months ago

Reviewers:
hazmat, mp+125054

Visibility:
Public.

Description

Implement expose button https://code.launchpad.net/~tveronezi/juju-ui/my-ui/+merge/125054 Requires: https://code.launchpad.net/~benji/juju-ui/service-edit-view-3/+merge/124996 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+178 lines, -47 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	1 chunk	+1 line, -1 line	1 comment	Download
M	app/store/env.js	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	app/templates/service.handlebars	View	1 chunk	+7 lines, -1 line	1 comment	Download
M	app/views/environment.js	View	5 chunks	+20 lines, -23 lines	1 comment	Download
M	app/views/service.js	View	6 chunks	+38 lines, -7 lines	1 comment	Download
M	app/views/utils.js	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	lib/views/stylesheet.less	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	test/test_service_view.js	View	14 chunks	+71 lines, -15 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hazmat

11 years, 7 months ago (2012-09-19 18:48:13 UTC) #2

https://codereview.appspot.com/6528046/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/6528046/diff/1/app/app.js#newcode212
app/app.js:212: this.showView('service', {service: service, db: this.db,
in this case we want the service bound to the generic name, so that the base
view model binding works.

https://codereview.appspot.com/6528046/diff/1/app/templates/service.handlebars
File app/templates/service.handlebars (right):

https://codereview.appspot.com/6528046/diff/1/app/templates/service.handlebar...
app/templates/service.handlebars:11: 
pls remove this from the button group rendering which are tabs and instead put
the icon into the informational overview on the right side of the service view.
Additionally his entire button group is implemented in each service view
template. It should get extracted to a handlebars partial (.partial files gets
compiled as such) and referenced from the service views.

https://codereview.appspot.com/6528046/diff/1/app/views/environment.js
File app/views/environment.js (right):

https://codereview.appspot.com/6528046/diff/1/app/views/environment.js#newcod...
app/views/environment.js:154: // Show whether or not the service is exposed
using an
this should already be on trunk, perhaps a stale diff.

https://codereview.appspot.com/6528046/diff/1/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/6528046/diff/1/app/views/service.js#newcode189
app/views/service.js:189: service = this.get('service'),
s/'service'/'model' for base view model binding.

Expand All Messages | Collapse All Messages