Issue 6527051: state: rename DialInfo to Open.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6527051: state: rename DialInfo to Open.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by rog

Modified:
11 years, 7 months ago

Reviewers:
mp+125235

Visibility:
Public.

Description

state: rename DialInfo to Open. It has the same semantics as the old Open so we keep the same name. "DialInfo" is more awkward and the current Dial function is of very limited use. https://code.launchpad.net/~rogpeppe/juju-core/073-rename-dial-open/+merge/125235 Requires: https://code.launchpad.net/~rogpeppe/juju-core/072-fix-state-loop/+merge/125230 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: rename DialInfo to Open. #

Patch Set 3 : state: rename DialInfo to Open. #

Patch Set 4 : state: rename DialInfo to Open. #

Patch Set 5 : state: rename DialInfo to Open. #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/state_test.go	View	1 2 3 4	1 chunk	+18 lines, -0 lines	0 comments	Download
M	state/unit.go	View	1 2 3 4	2 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rog

11 years, 7 months ago (2012-09-19 15:04:28 UTC) #5

*** Submitted:

state: rename DialInfo to Open.

It has the same semantics as the old Open so we keep
the same name. "DialInfo" is more awkward and the
current Dial function is of very limited use.

R=niemeyer
CC=
https://codereview.appspot.com/6527051

Expand All Messages | Collapse All Messages