note-spacing: pad accidentals from neighbor as far as from parent; issue 3869

note-spacing: pad accidentals from neighbor as far as from parent; issue 3869

[janek, 2014-02-20 22:21:37]

I would add a comment
"TODO: this hard-coded value should be removed when
http://code.google.com/p/lilypond/issues/detail?id=2142
will be taken care of"

Otherwise LGTM.  Thanks for working on this, and sorry i didn't review it
earlier - i missed the announcement.

best,
Janek

[janek, 2014-02-22 14:34:56]

Hmm.  After some thinking i'm not so sure i like this, because it also affects
note-note spacing (which becomes less compressible) - see for example:

\repeat unfold 32 { f'16 f' f' f' \noBreak }

I think it may be better to leave the situation as-is.  I apologize for not
noticing this problem earlier.

best,
Janek

[Keith, 2014-02-23 03:57:17]

On 2014/02/20 22:21:37, janek wrote:
> I would add a comment
> "TODO: this hard-coded value should be removed when
> http://code.google.com/p/lilypond/issues/detail?id=2142
> will be taken care of"
> 
What does 'hard-coded' mean here?
If there is a setting of 'padding' padding it gets used.  If there is no setting
at all, 0.2 is used instead.
After you fix issue 2142 and remove the value, if make some input where I set
padding to empty '() or ##f or something, what will happen?

[janek, 2014-02-23 16:54:43]

2014-02-23 4:57 GMT+01:00  <k-ohara5a5a@oco.net>:
> Reviewers: janek,
>
> Message:
>
> On 2014/02/20 22:21:37, janek wrote:
>>
>> I would add a comment
>> "TODO: this hard-coded value should be removed when
>> http://code.google.com/p/lilypond/issues/detail?id=2142
>> will be taken care of"
>
>
> What does 'hard-coded' mean here?
> If there is a setting of 'padding' padding it gets used.  If there is no
> setting at all, 0.2 is used instead.
> After you fix issue 2142 and remove the value, if make some input where
> I set padding to empty '() or ##f or something, what will happen?

Sorry, i obviously didn't understand what you wrote about surprising
grob type and why you made the change in this place.

Anyway, what you suggested in
http://code.google.com/p/lilypond/issues/detail?id=3869#c4 seems to be
a better way to handle this.  Thanks a lot!
Janek

[lemzwerg, 2014-11-16 05:34:28]

Aaand another LGTM :-)