Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(402)

Issue 6523043: code review 6523043: os: use small writes during console io (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 4 months ago by brainman
Modified:
8 years, 4 months ago
Reviewers:
CC:
golang-dev, bradfitz, rsc
Visibility:
Public.

Description

os: use small writes during console io Fixes issue 3767

Patch Set 1 #

Patch Set 2 : diff -r 195e4fc09b2d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 195e4fc09b2d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 195e4fc09b2d https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r 7cbb8aa08f8e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M src/pkg/os/file_windows.go View 1 2 3 1 chunk +12 lines, -2 lines 0 comments Download
M src/pkg/os/os_test.go View 1 2 3 4 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 7
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
8 years, 4 months ago (2012-09-18 02:02:22 UTC) #1
bradfitz
A comment above "const maxWrite = 16000" would be nice, both explaining the rationale of ...
8 years, 4 months ago (2012-09-18 06:37:11 UTC) #2
brainman
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
8 years, 4 months ago (2012-09-18 07:05:05 UTC) #3
brainman
On 2012/09/18 06:37:11, bradfitz wrote: > A comment above "const maxWrite = 16000" would be ...
8 years, 4 months ago (2012-09-18 07:05:08 UTC) #4
rsc
LGTM
8 years, 4 months ago (2012-09-18 15:17:32 UTC) #5
bradfitz
LGTM https://codereview.appspot.com/6523043/diff/3003/src/pkg/os/os_test.go File src/pkg/os/os_test.go (right): https://codereview.appspot.com/6523043/diff/3003/src/pkg/os/os_test.go#newcode1075 src/pkg/os/os_test.go:1075: t.Logf("skipping test because it floods console with output") ...
8 years, 4 months ago (2012-09-18 15:24:19 UTC) #6
brainman
8 years, 4 months ago (2012-09-19 06:55:28 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=b0c749cc5654 ***

os: use small writes during console io

Fixes issue 3767

R=golang-dev, bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/6523043

http://codereview.appspot.com/6523043/diff/3003/src/pkg/os/os_test.go
File src/pkg/os/os_test.go (right):

http://codereview.appspot.com/6523043/diff/3003/src/pkg/os/os_test.go#newcode...
src/pkg/os/os_test.go:1075: t.Logf("skipping test because it floods console with
output")
On 2012/09/18 15:24:19, bradfitz wrote:
> maybe reference the flag:
> 
> "skipping console-flooding test; enable with -large_write"
> 

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b