code review 6488127: misc\cgo\test and test\bench\go1: enable these tests on...

misc/cgo/test and test/bench/go1: enable these tests on windows

[brainman, 2012-09-14 07:35:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[brainman, 2012-09-14 07:36:05]

Please, note that I can submit this CL only once our windows builders are
updated to:

changeset:   14080:5b1777d3a58e
tag:         tip
user:        Alex Brainman <alex.brainman@gmail.com>
date:        Fri Sep 14 12:53:30 2012 +1000
summary:     misc/dashboard/builder: use c:\ as default buildroot on windows

I can update windows-amd64 builder myself, if I am allowed to, and if it hasn't
been replaced with new computer. But I have no access to windows-386. Please,
help. Thank you.

Alex

[r, 2012-09-14 14:05:09]

LGTM

[brainman, 2012-09-15 12:40:09]

I have updated windows-amd64 builder. Now I need windows-386 updated too before
I can submit. If someone can help. Alternatively let me know what its
credentials are and I will do it myself. Thank you.

Alex

[bradfitzgoog, 2012-09-15 13:52:55]

Updated? How?
On Sep 15, 2012 5:40 AM, <alex.brainman@gmail.com> wrote:

> I have updated windows-amd64 builder. Now I need windows-386 updated too
> before I can submit. If someone can help. Alternatively let me know what
> its credentials are and I will do it myself. Thank you.
>
> Alex
>
>
http://codereview.appspot.com/**6488127/<http://codereview.appspot.com/6488127/>
>

[brainman, 2012-09-15 22:30:34]

On 2012/09/15 13:52:55, bradfitzgoog wrote:
> Updated? How?

Just update repo to the tip and rebuild go builder (and restart it):

http://codereview.appspot.com/6488127/#msg2

Thank you.

Alex

[brainman, 2012-09-19 02:07:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=28e350401401 ***

misc/cgo/test and test/bench/go1: enable these tests on windows

R=golang-dev, r, bradfitz
CC=golang-dev
http://codereview.appspot.com/6488127