Issue 6510043: mstate: stop presence watcher on State.Close

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6510043: mstate: stop presence watcher on State.Close

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by niemeyer

Modified:
11 years, 8 months ago

Reviewers:
mp+123187, fwereade

Visibility:
Public.

Description

mstate: stop presence watcher on State.Close Also cleans up some trivials in the presence package. https://code.launchpad.net/~niemeyer/juju-core/stop-presence-watcher/+merge/123187 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : mstate: stop presence watcher on State.Close #

Patch Set 3 : mstate: stop presence watcher on State.Close #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -16 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mstate/open.go	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	mstate/presence/presence.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mstate/presence/presence_test.go	View	3 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

11 years, 8 months ago (2012-09-06 22:18:55 UTC) #4

*** Submitted:

mstate: stop presence watcher on State.Close

Also cleans up some trivials in the presence package.

R=fwereade
CC=
https://codereview.appspot.com/6510043

Expand All Messages | Collapse All Messages