Issue 6506094: ibus-daemon: trigger engine to send RegisterProperties when panel appears

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6506094: ibus-daemon: trigger engine to send RegisterProperties when panel appears (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by Daiki Ueno

Modified:
11 years, 9 months ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ibus-daemon: trigger engine to send RegisterProperties when panel appears BUG=none

Patch Set 2 : keep a copy of properties inside BusEngineProxy #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -4 lines)			Patch
M	bus/engineproxy.h	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	bus/engineproxy.c	View	1	8 chunks	+47 lines, -2 lines	0 comments	Download
M	bus/ibusimpl.c	View	1	2 chunks	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Daiki Ueno

Related to https://codereview.appspot.com/6492086 Perhaps it might be good to send RegisterProperties when panel appears on ...

11 years, 9 months ago (2012-09-10 13:11:28 UTC) #1

Peng

https://codereview.appspot.com/6506094/diff/1/bus/ibusimpl.c File bus/ibusimpl.c (right): https://codereview.appspot.com/6506094/diff/1/bus/ibusimpl.c#newcode280 bus/ibusimpl.c:280: BusEngineProxy *engine; Could we keep a copy of properties ...

11 years, 9 months ago (2012-09-10 21:41:16 UTC) #2

Daiki Ueno

11 years, 9 months ago (2012-09-11 07:56:53 UTC) #3

lgtm

Expand All Messages | Collapse All Messages