Prevent IME menu being empty when focus out

Prevent IME menu being empty when focus out

Previously ibus-daemon did not make fake_context focused when focus-out, while it is supposed to do.

BUG=none

[Daiki Ueno, 2012-09-06 02:40:35]

Now that global-engine is enabled, it looks a bit odd that IME menus are lost
when focus out.

[Peng, 2012-09-06 23:07:26]

https://codereview.appspot.com/6492086/diff/3001/bus/ibusimpl.c
File bus/ibusimpl.c (right):

https://codereview.appspot.com/6492086/diff/3001/bus/ibusimpl.c#newcode1155
bus/ibusimpl.c:1155: context = ibus->fake_context;
I remember if there is no context has focus, ibus will make the fake_context
focused. If it is true, the problem should not happen. So maybe we did not focus
in the fake_context correctly.?

[Daiki Ueno, 2012-09-07 01:09:33]

https://codereview.appspot.com/6492086/diff/3001/bus/ibusimpl.c
File bus/ibusimpl.c (right):

https://codereview.appspot.com/6492086/diff/3001/bus/ibusimpl.c#newcode1155
bus/ibusimpl.c:1155: context = ibus->fake_context;
On 2012/09/06 23:07:26, Peng wrote:
> I remember if there is no context has focus, ibus will make the fake_context
> focused. If it is true, the problem should not happen. So maybe we did not
focus
> in the fake_context correctly.?

Right.  The logic that makes fake_context focused is in
bus_ibus_impl_set_focused_context():

    if (context == NULL && ibus->use_global_engine) {
        context = ibus->fake_context;
    }

however, the focus out handler (_context_focus_out_cb()) does not call it:

    if (ibus->use_global_engine == FALSE) {
        /* Do not change the focused context, if use_global_engine option is
enabled.
         * If focused context swith to NULL, users can not swith engine in panel
anymore.
         **/
        bus_ibus_impl_set_focused_context (ibus, NULL);
    }

I think the comment above is outdated and not correct now.  I've updated the CL.

[Peng, 2012-09-07 01:35:32]

https://codereview.appspot.com/6492086/diff/3002/bus/ibusimpl.c
File bus/ibusimpl.c (right):

https://codereview.appspot.com/6492086/diff/3002/bus/ibusimpl.c#newcode1125
bus/ibusimpl.c:1125: if (ibus->use_global_engine && context ==
ibus->fake_context) {
Is it necessary? I think bus_input_context_set_engine(context, engine) will call
bus_engine_proxy_focus_in().

https://codereview.appspot.com/6492086/diff/3002/bus/inputcontext.c
File bus/inputcontext.c (right):

https://codereview.appspot.com/6492086/diff/3002/bus/inputcontext.c#newcode1134
bus/inputcontext.c:1134: /* workaround: don't reset properties if global engine
is used */
Is it still necessary?

[Daiki Ueno, 2012-09-07 01:56:04]

Thanks, updated the CL and the summary.

https://codereview.appspot.com/6492086/diff/3002/bus/ibusimpl.c
File bus/ibusimpl.c (right):

https://codereview.appspot.com/6492086/diff/3002/bus/ibusimpl.c#newcode1125
bus/ibusimpl.c:1125: if (ibus->use_global_engine && context ==
ibus->fake_context) {
On 2012/09/07 01:35:32, Peng wrote:
> Is it necessary? I think bus_input_context_set_engine(context, engine) will
call
> bus_engine_proxy_focus_in().

Right, good to know that.  Removed this part.

https://codereview.appspot.com/6492086/diff/3002/bus/inputcontext.c
File bus/inputcontext.c (right):

https://codereview.appspot.com/6492086/diff/3002/bus/inputcontext.c#newcode1134
bus/inputcontext.c:1134: /* workaround: don't reset properties if global engine
is used */
On 2012/09/07 01:35:32, Peng wrote:
> Is it still necessary?

Removed as well, as later call to bus_impl_set_focused_context() will request
properties.

[Peng, 2012-09-07 02:27:41]

lgtm