Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(232)

Issue 65047: ns-3 ipv4 changes

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Tom Henderson
Modified:
13 years, 6 months ago
CC:
ns-developers_isi.edu
Visibility:
Public.

Patch Set 1 #

Total comments: 22
Unified diffs Side-by-side diffs Delta from patch set Stats (+4134 lines, -3121 lines) Patch
M CHANGES.html View 1 chunk +83 lines, -0 lines 0 comments Download
M examples/csma-multicast.cc View 2 chunks +1 line, -5 lines 0 comments Download
M examples/emu-ping.cc View 1 chunk +3 lines, -1 line 0 comments Download
M examples/static-routing-slash32.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/applications/packet-sink/packet-sink.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/applications/udp-echo/udp-echo-server.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/devices/tap-bridge/tap-bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/helper/internet-stack-helper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/helper/internet-stack-helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/helper/ipv4-address-helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/helper/ipv4-interface-container.h View 1 chunk +4 lines, -1 line 0 comments Download
A src/helper/ipv4-static-routing-helper.h View 1 chunk +63 lines, -0 lines 0 comments Download
A src/helper/ipv4-static-routing-helper.cc View 1 chunk +189 lines, -0 lines 1 comment Download
M src/helper/olsr-helper.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/helper/packet-sink-helper.cc View 1 chunk +0 lines, -16 lines 0 comments Download
R src/helper/static-multicast-route-helper.h View 1 chunk +0 lines, -57 lines 0 comments Download
R src/helper/static-multicast-route-helper.cc View 1 chunk +0 lines, -153 lines 0 comments Download
M src/helper/wscript View 2 chunks +2 lines, -2 lines 0 comments Download
M src/internet-stack/icmpv4-l4-protocol.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/internet-stack/icmpv4-l4-protocol.cc View 4 chunks +21 lines, -10 lines 1 comment Download
M src/internet-stack/internet-stack.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/internet-stack/internet-stack.cc View 2 chunks +11 lines, -0 lines 1 comment Download
M src/internet-stack/ipv4-global-routing.h View 5 chunks +24 lines, -78 lines 0 comments Download
M src/internet-stack/ipv4-global-routing.cc View 10 chunks +117 lines, -77 lines 2 comments Download
M src/internet-stack/ipv4-interface.h View 4 chunks +18 lines, -5 lines 1 comment Download
M src/internet-stack/ipv4-interface.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/internet-stack/ipv4-l3-protocol.h View 8 chunks +41 lines, -83 lines 0 comments Download
M src/internet-stack/ipv4-l3-protocol.cc View 22 chunks +276 lines, -601 lines 1 comment Download
A src/internet-stack/ipv4-list-routing-impl.h View 1 chunk +65 lines, -0 lines 0 comments Download
A src/internet-stack/ipv4-list-routing-impl.cc View 1 chunk +282 lines, -0 lines 1 comment Download
M src/internet-stack/ipv4-raw-socket-impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/internet-stack/ipv4-raw-socket-impl.cc View 1 chunk +17 lines, -7 lines 0 comments Download
R src/internet-stack/ipv4-static-routing.h View 1 chunk +0 lines, -506 lines 0 comments Download
R src/internet-stack/ipv4-static-routing.cc View 1 chunk +0 lines, -654 lines 0 comments Download
A src/internet-stack/ipv4-static-routing-impl.h View 1 chunk +367 lines, -0 lines 1 comment Download
A src/internet-stack/ipv4-static-routing-impl.cc View 1 chunk +569 lines, -0 lines 0 comments Download
M src/internet-stack/nsc-tcp-l4-protocol.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/internet-stack/tcp-l4-protocol.cc View 3 chunks +19 lines, -2 lines 0 comments Download
M src/internet-stack/tcp-socket-impl.cc View 6 chunks +57 lines, -27 lines 1 comment Download
M src/internet-stack/udp-l4-protocol.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/internet-stack/udp-l4-protocol.cc View 3 chunks +32 lines, -1 line 0 comments Download
M src/internet-stack/udp-socket-impl.h View 2 chunks +14 lines, -6 lines 0 comments Download
M src/internet-stack/udp-socket-impl.cc View 7 chunks +83 lines, -13 lines 1 comment Download
M src/internet-stack/wscript View 1 chunk +2 lines, -1 line 0 comments Download
M src/node/address-utils.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/node/address-utils.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/node/ipv4.h View 5 chunks +94 lines, -353 lines 1 comment Download
M src/node/ipv4.cc View 3 chunks +15 lines, -20 lines 0 comments Download
M src/node/ipv4-address.cc View 1 chunk +1 line, -0 lines 0 comments Download
A src/node/ipv4-list-routing.h View 1 chunk +61 lines, -0 lines 0 comments Download
A src/node/ipv4-list-routing.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/node/ipv4-route.h View 3 chunks +46 lines, -122 lines 0 comments Download
M src/node/ipv4-route.cc View 3 chunks +57 lines, -249 lines 0 comments Download
A src/node/ipv4-routing-protocol.h View 1 chunk +97 lines, -0 lines 0 comments Download
A src/node/ipv4-routing-protocol.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A src/node/ipv4-routing-table-entry.h View 1 chunk +181 lines, -0 lines 0 comments Download
A src/node/ipv4-routing-table-entry.cc View 1 chunk +333 lines, -0 lines 0 comments Download
A src/node/ipv4-static-routing.h View 1 chunk +366 lines, -0 lines 0 comments Download
A src/node/ipv4-static-routing.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/node/udp-socket.h View 2 chunks +56 lines, -5 lines 0 comments Download
M src/node/udp-socket.cc View 2 chunks +15 lines, -2 lines 0 comments Download
M src/node/wscript View 2 chunks +9 lines, -0 lines 0 comments Download
M src/routing/global-routing/global-route-manager-impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/routing/global-routing/global-route-manager-impl.cc View 12 chunks +94 lines, -33 lines 1 comment Download
M src/routing/olsr/olsr-routing-protocol.h View 1 chunk +4 lines, -7 lines 0 comments Download
M src/routing/olsr/olsr-routing-protocol.cc View 3 chunks +142 lines, -6 lines 9 comments Download

Messages

Total messages: 3
faker.moatamri
Hello, Here is some comments on the patch to be pushed to the server, the ...
13 years, 6 months ago (2009-05-15 07:55:25 UTC) #1
Tom Henderson
On 2009/05/15 07:55:25, faker.moatamri wrote: > Hello, > Here is some comments on the patch ...
13 years, 6 months ago (2009-05-18 04:52:16 UTC) #2
Mathieu Lacage
13 years, 6 months ago (2009-05-19 15:18:34 UTC) #3
+1 for merging.

http://codereview.appspot.com/65047/diff/1/27
File src/internet-stack/ipv4-interface.h (right):

http://codereview.appspot.com/65047/diff/1/27#newcode100
Line 100: * XXX deprecated?  This is duplicate API to GetDevice ()->GetMtu ()
ok, let's kill it.

http://codereview.appspot.com/65047/diff/1/30
File src/internet-stack/ipv4-list-routing-impl.cc (right):

http://codereview.appspot.com/65047/diff/1/30#newcode255
Line 255: srp = dynamic_cast<Ipv4StaticRouting*>
(PeekPointer((*rprotoIter).second));
DynamicCast<Ipv4StaticRouting> is your friend.

http://codereview.appspot.com/65047/diff/1/60
File src/node/ipv4.h (right):

http://codereview.appspot.com/65047/diff/1/60#newcode128
Line 128: virtual int32_t GetInterfaceForAddress (Ipv4Address address) const =
0;
I liked the previous name better: Find makes it clear that this is a O(n)
operation, not O(1). Not a big deal either way.

http://codereview.appspot.com/65047/diff/1/64
File src/routing/global-routing/global-route-manager-impl.cc (right):

http://codereview.appspot.com/65047/diff/1/64#newcode1438
Line 1438: #if 0
dead code, remove it ?

http://codereview.appspot.com/65047/diff/1/66
File src/routing/olsr/olsr-routing-protocol.cc (right):

http://codereview.appspot.com/65047/diff/1/66#newcode2588
Line 2588: << " interface=" << entry2.interface);      NS_LOG_DEBUG ("Found
route to " << rtentry->GetDestination () << " via nh " << rtentry->GetGateway ()
<< " with source addr " << rtentry->GetSource () << " and output dev " <<
rtentry->GetOutputDevice());
missing cariage return

http://codereview.appspot.com/65047/diff/1/66#newcode2596
Line 2596: #if 0
If code is dead, can you kill it ?

http://codereview.appspot.com/65047/diff/1/66#newcode2613
Line 2613: << " --> NOT FOUND; ** Dumping routing table...");      for
(std::map<Ipv4Address, RoutingTableEntry>::const_iterator iter = m_table.begin
();
missing cariage return

http://codereview.appspot.com/65047/diff/1/66#newcode2627
Line 2627: const Ipv4Header &header, Ptr<const NetDevice> idev,                 
          UnicastForwardCallback ucb, MulticastForwardCallback mcb,
indenting looks all broken.

http://codereview.appspot.com/65047/diff/1/66#newcode2675
Line 2675: << " --> NOT FOUND; ** Dumping routing table...");      for
(std::map<Ipv4Address, RoutingTableEntry>::const_iterator iter = m_table.begin
();
missing caarriage return ?

http://codereview.appspot.com/65047/diff/1/66#newcode2688
Line 2688: #if 0
If this code is dead, can you kill it ?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b