Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4364)

Issue 6503109: build: add .lbox.check

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by niemeyer
Modified:
11 years, 7 months ago
Reviewers:
aram, mp+124018
Visibility:
Public.

Description

build: add .lbox.check This will check for formatting issues, both at proposal time and at submit time (on the merged branch). It requires an up-to-date lbox to work. https://code.launchpad.net/~niemeyer/juju-core/lbox-check/+merge/124018 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : build: add .lbox.check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
A .lbox.check View 1 chunk +10 lines, -0 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
niemeyer
Please take a look.
11 years, 8 months ago (2012-09-12 17:51:02 UTC) #1
niemeyer
<wrtp> niemeyer: yay! LGTM
11 years, 8 months ago (2012-09-12 19:11:13 UTC) #2
niemeyer
*** Submitted: build: add .lbox.check This will check for formatting issues, both at proposal time ...
11 years, 8 months ago (2012-09-12 19:14:11 UTC) #3
aram
11 years, 7 months ago (2012-09-12 23:08:51 UTC) #4
Finally! I've wanted this since forever.

Thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b