Issue 6501069: ec2: fix signing bug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6501069: ec2: fix signing bug

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rog

Modified:
11 years, 8 months ago

Reviewers:
mp+122204

Visibility:
Public.

Description

ec2: fix signing bug Also fix live tests - the default group was satisfying some of the group filtering tests. We add a default group to the test server to more closely match reality. https://code.launchpad.net/~rogpeppe/goamz/ec2-fix-sig/+merge/122204 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : ec2: fix signing bug #

Total comments: 4

Patch Set 3 : ec2: fix signing bug #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -101 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ec2/ec2.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ec2/ec2t_test.go	View	1 2	6 chunks	+72 lines, -99 lines	0 comments	Download
M	ec2/ec2test/server.go	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
M	ec2/suite_test.go	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

Thanks for the fix. LGTM with one trivial: https://codereview.appspot.com/6501069/diff/2001/ec2/ec2t_test.go File ec2/ec2t_test.go (right): https://codereview.appspot.com/6501069/diff/2001/ec2/ec2t_test.go#newcode326 ec2/ec2t_test.go:326: // ...

11 years, 8 months ago (2012-08-31 16:12:04 UTC) #2

rog

11 years, 8 months ago (2012-08-31 16:34:20 UTC) #3

*** Submitted:

ec2: fix signing bug

Also fix live tests - the default group was satisfying some of the
group filtering tests. We add a default group to the test server
to more closely match reality.

R=niemeyer
CC=
https://codereview.appspot.com/6501069

https://codereview.appspot.com/6501069/diff/2001/ec2/ec2t_test.go
File ec2/ec2t_test.go (right):

https://codereview.appspot.com/6501069/diff/2001/ec2/ec2t_test.go#newcode326
ec2/ec2t_test.go:326: // 0. check that Instances returns all instances.
On 2012/08/31 16:12:04, niemeyer wrote:
> Let's please not number things like that. No point in making life painful when
> reordering or inserting new tests.

Done.

https://codereview.appspot.com/6501069/diff/2001/ec2/ec2t_test.go#newcode508
ec2/ec2t_test.go:508: // 0. check that SecurityGroups returns all groups.
On 2012/08/31 16:12:04, niemeyer wrote:
> Ditto.

Done.

Expand All Messages | Collapse All Messages