environs: add BootstrapConfig

environs: add BootstrapConfig

Also add flags to environs.FindTools and environs.BestTools,
LoggingSuite to JujuSuite, and make the Config in cloudinit
a *config.Config.

https://code.launchpad.net/~rogpeppe/juju-core/042-environs-bootstrap-config/+merge/122121

(do not edit description out of merge proposal)

[rog, 2012-08-30 18:36:09]

Please take a look.

[niemeyer, 2012-08-30 23:01:40]

This is fantastic Roger, thank you!

A few suggestions only, and LGTM.

https://codereview.appspot.com/6500052/diff/2001/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/6500052/diff/2001/environs/cloudinit/cloudinit...
environs/cloudinit/cloudinit.go:61: Config *config.Config
Nice, thanks for fixing that as well.

https://codereview.appspot.com/6500052/diff/2001/environs/tools.go
File environs/tools.go (right):

https://codereview.appspot.com/6500052/diff/2001/environs/tools.go#newcode223
environs/tools.go:223: allowDev := vers.IsDev() || flags&DevVersion != 0
allowHigher := flags&HighestVersion != 0

https://codereview.appspot.com/6500052/diff/2001/environs/tools.go#newcode389
environs/tools.go:389: // be chosen. The default is to choose a version no
higher than specified.
// HighestVersion indicates that versions above the version being
// searched for may be included in the search. The default behavior
// is to search for versions <= the one provided.

Please omit the (minor, patch) information. This is CompatVersion's job.

https://codereview.appspot.com/6500052/diff/2001/environs/tools.go#newcode394
environs/tools.go:394: // version.
// DevVersion includes development versions in the search, even
// when the version to match against isn't a development version.

https://codereview.appspot.com/6500052/diff/2001/environs/tools.go#newcode398
environs/tools.go:398: // must be the same as specified. It is not yet
implemented.
s/It is not yet implemented./At the moment this flag is required./

https://codereview.appspot.com/6500052/diff/2001/environs/tools_test.go
File environs/tools_test.go (right):

https://codereview.appspot.com/6500052/diff/2001/environs/tools_test.go#newco...
environs/tools_test.go:387: flags environs.ToolsSearchFlags
go fmt

[dave_cheney.net, 2012-08-31 01:58:20]

Excellent. This fixed my deploy problems

lucky(~) % time (juju bootstrap --upload-tools; juju deploy mongodb ; juju
status)
machines:
  1:
    proposed-agent-version: 0.0.0
    instance-id: i-5ec70124
    agent-version: 0.0.0
  0:
    instance-id: i-f2bb7d88
    dns-name: ec2-107-20-94-133.compute-1.amazonaws.com
    proposed-agent-version: 0.0.0
    agent-version: 0.0.1
services:
  mongodb:
    charm: mongodb
    exposed: false
    units:
      mongodb/0:
        agent-version: 0.0.0
        proposed-agent-version: 0.0.0
        machine: 1
        status: pending

real    4m26.279s
user    0m7.064s
sys     0m0.712s

[rog, 2012-08-31 05:29:37]

*** Submitted:

environs: add BootstrapConfig

Also add flags to environs.FindTools and environs.BestTools,
LoggingSuite to JujuSuite, and make the Config in cloudinit
a *config.Config.

R=niemeyer, dfc
CC=
https://codereview.appspot.com/6500052

https://codereview.appspot.com/6500052/diff/2001/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/6500052/diff/2001/environs/cloudinit/cloudinit...
environs/cloudinit/cloudinit.go:61: Config *config.Config
On 2012/08/30 23:01:40, niemeyer wrote:
> Nice, thanks for fixing that as well.

My pleasure :-)

https://codereview.appspot.com/6500052/diff/2001/environs/tools.go
File environs/tools.go (right):

https://codereview.appspot.com/6500052/diff/2001/environs/tools.go#newcode223
environs/tools.go:223: allowDev := vers.IsDev() || flags&DevVersion != 0
On 2012/08/30 23:01:40, niemeyer wrote:
> allowHigher := flags&HighestVersion != 0

Done.

https://codereview.appspot.com/6500052/diff/2001/environs/tools.go#newcode389
environs/tools.go:389: // be chosen. The default is to choose a version no
higher than specified.
On 2012/08/30 23:01:40, niemeyer wrote:
> // HighestVersion indicates that versions above the version being
> // searched for may be included in the search. The default behavior
> // is to search for versions <= the one provided.
> 
> Please omit the (minor, patch) information. This is CompatVersion's job.

Nice description. Done.

https://codereview.appspot.com/6500052/diff/2001/environs/tools.go#newcode394
environs/tools.go:394: // version.
On 2012/08/30 23:01:40, niemeyer wrote:
> // DevVersion includes development versions in the search, even
> // when the version to match against isn't a development version.

Also nice. Done.

https://codereview.appspot.com/6500052/diff/2001/environs/tools.go#newcode398
environs/tools.go:398: // must be the same as specified. It is not yet
implemented.
On 2012/08/30 23:01:40, niemeyer wrote:
> s/It is not yet implemented./At the moment this flag is required./

Done.

https://codereview.appspot.com/6500052/diff/2001/environs/tools_test.go
File environs/tools_test.go (right):

https://codereview.appspot.com/6500052/diff/2001/environs/tools_test.go#newco...
environs/tools_test.go:387: flags environs.ToolsSearchFlags
On 2012/08/30 23:01:40, niemeyer wrote:
> go fmt

Done.