Issue 6499055: environs/config: add support for agent version.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6499055: environs/config: add support for agent version.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rog

Modified:
11 years, 8 months ago

Reviewers:
mp+122016

Visibility:
Public.

Description

environs/config: add support for agent version. Also adjust documentation for schema.Omit slightly and add a test. https://code.launchpad.net/~rogpeppe/juju-core/041-config-agent-version/+merge/122016 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/config: add support for agent version. #

Total comments: 3

Patch Set 3 : environs/config: add support for agent version. #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -5 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/config/config.go	View	1 2	3 chunks	+23 lines, -0 lines	0 comments	Download
M	environs/config/config_test.go	View	1 2	4 chunks	+27 lines, -3 lines	0 comments	Download
M	schema/schema.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	schema/schema_test.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6499055/diff/2001/environs/config/config.go File environs/config/config.go (right): https://codereview.appspot.com/6499055/diff/2001/environs/config/config.go#newcode95 environs/config/config.go:95: panic(err) // We should have checked it earlier. ...

11 years, 8 months ago (2012-08-30 10:11:55 UTC) #2

rog

11 years, 8 months ago (2012-08-30 12:22:13 UTC) #3

*** Submitted:

environs/config: add support for agent version.

Also adjust documentation for schema.Omit slightly
and add a test.

R=niemeyer
CC=
https://codereview.appspot.com/6499055

Expand All Messages | Collapse All Messages