|
|
Created:
10 years, 9 months ago by adonovan Modified:
10 years, 4 months ago Reviewers:
CC:
golang-dev Visibility:
Public. |
Descriptioncodereview: advise users to install 'easy_install'.
My first go commit. :)
Patch Set 1 #Patch Set 2 : diff -r 008d345d81e0 https://code.google.com/p/go/ #Patch Set 3 : diff -r 008d345d81e0 https://code.google.com/p/go/ #MessagesTotal messages: 14
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
Sign in to reply to this message.
Really? I've found easy-install to not be easy and not install things. -rob
Sign in to reply to this message.
That may be, but if we are advising people to use it, we may as well advise them on how to get it. It wasn't installed on my workstation, for example, and I'd never heard of it before. On 29 August 2012 17:44, Rob Pike <r@golang.org> wrote: > Really? I've found easy-install to not be easy and not install things. > > -rob
Sign in to reply to this message.
On Wed, Aug 29, 2012 at 2:52 PM, Alan Donovan <adonovan@google.com> wrote: > That may be, but if we are advising people to use it, we may as well > advise them on how to get it. > It wasn't installed on my workstation, for example, and I'd never > heard of it before. That's my point. Is this the best way? -rob
Sign in to reply to this message.
The Go documentation at http://golang.org/doc/install/source#mercurial suggests downloading Mercurial from http://mercurial.selenic.com/downloads/ Would that make more sense? On Wednesday, August 29, 2012 4:53:21 PM UTC-5, Rob Pike wrote: > > On Wed, Aug 29, 2012 at 2:52 PM, Alan Donovan <adon...@google.com<javascript:>> > wrote: > > That may be, but if we are advising people to use it, we may as well > > advise them on how to get it. > > It wasn't installed on my workstation, for example, and I'd never > > heard of it before. > > That's my point. Is this the best way? > > -rob >
Sign in to reply to this message.
(as the only option suggested) On Wednesday, August 29, 2012 9:37:11 PM UTC-5, rh wrote: > > The Go documentation at http://golang.org/doc/install/source#mercurial > suggests downloading Mercurial from > http://mercurial.selenic.com/downloads/ > > Would that make more sense? > > On Wednesday, August 29, 2012 4:53:21 PM UTC-5, Rob Pike wrote: >> >> On Wed, Aug 29, 2012 at 2:52 PM, Alan Donovan <adon...@google.com> >> wrote: >> > That may be, but if we are advising people to use it, we may as well >> > advise them on how to get it. >> > It wasn't installed on my workstation, for example, and I'd never >> > heard of it before. >> >> That's my point. Is this the best way? >> >> -rob >> >
Sign in to reply to this message.
Yes. Don't use easy_install. Let's fix it that way instead, to agree with the mercurial documentation. -rob
Sign in to reply to this message.
adonovan, are you still interested in completing this CL? I'd be happy to, if not.
Sign in to reply to this message.
not lgtm We decided not to advise the use of easy_install. It used to be there but it is gone now. The copy there was too old: best to get it straight from the Mercurial site.
Sign in to reply to this message.
It seems like gocodereview doesn't recognize the lowercase "not 1gtm"
Sign in to reply to this message.
Robert, thanks for your offer; if you'd like to take it, please be my guest. This CL has been languishing because it's not close to the top of my list of priorities and I haven't had a chance to test out an alternative sequence of commands that actually works on a clean machine. rsc: don't worry, I realise this is ¬LGTM. On 1 October 2012 15:16, <rsc@golang.org> wrote: > not lgtm > > We decided not to advise the use of easy_install. It used to be there > but it is gone now. The copy there was too old: best to get it straight > from the Mercurial site. > > > https://codereview.appspot.com/6499053/
Sign in to reply to this message.
Thank you. I have created http://codereview.appspot.com/6584059 On 2012/10/01 19:38:15, adonovan wrote: > Robert, thanks for your offer; if you'd like to take it, please be my > guest. This CL has been languishing because it's not close to the > top of my list of priorities and I haven't had a chance to test out an > alternative sequence of commands that actually works on a clean > machine. > > rsc: don't worry, I realise this is ¬LGTM. > > On 1 October 2012 15:16, <mailto:rsc@golang.org> wrote: > > not lgtm > > > > We decided not to advise the use of easy_install. It used to be there > > but it is gone now. The copy there was too old: best to get it straight > > from the Mercurial site. > > > > > > https://codereview.appspot.com/6499053/
Sign in to reply to this message.
|