container: fix jujud arguments.

container: fix jujud arguments.

Unfortunately we can't test this properly until
we have something using container to do a deployment,
which won't happen until the uniter integration
branch (https://codereview.appspot.com/6497109/)
is merged.

We also add a Unit.AgentName method, meaning
that we can use the same logic in various places that
need to calculate an agent name from a unit.

We also change the path where unit data is stored
($vardir/agents/unit-agent-name) so that any other
agent data can have an entry in the agents directory too.

https://code.launchpad.net/~rogpeppe/juju-core/056-container-fix/+merge/123795

Requires: https://code.launchpad.net/~rogpeppe/juju-core/055-no-global-vardir/+merge/123316

(do not edit description out of merge proposal)

[rog, 2012-09-12 15:03:32]

Please take a look.

[fwereade, 2012-09-12 15:11:03]

On 2012/09/12 15:03:32, rog wrote:
> Please take a look.

Much nicer; LGTM

[rog, 2012-09-12 18:11:25]

Please take a look.

[niemeyer, 2012-09-12 21:25:30]

Good stuff, LGTM. Only one trivial suggestion:

https://codereview.appspot.com/6498117/diff/9002/state/unit.go
File state/unit.go (right):

https://codereview.appspot.com/6498117/diff/9002/state/unit.go#newcode485
state/unit.go:485: func (u *Unit) AgentName() string {
Can we please call this as PathKey? That's really what it is. Its main property
is being unique among other entities and having no slashes so that we can use it
in a path without trouble. Anyone that wishes such properties can use it, no
matter if it's dealing with the agent or not. We can document it as such as
well.

[rog, 2012-09-12 22:53:53]

*** Submitted:

container: fix jujud arguments.

Unfortunately we can't test this properly until
we have something using container to do a deployment,
which won't happen until the uniter integration
branch (https://codereview.appspot.com/6497109/)
is merged.

We also add a Unit.AgentName method, meaning
that we can use the same logic in various places that
need to calculate an agent name from a unit.

We also change the path where unit data is stored
($vardir/agents/unit-agent-name) so that any other
agent data can have an entry in the agents directory too.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6498117

https://codereview.appspot.com/6498117/diff/9002/state/unit.go
File state/unit.go (right):

https://codereview.appspot.com/6498117/diff/9002/state/unit.go#newcode485
state/unit.go:485: func (u *Unit) AgentName() string {
On 2012/09/12 21:25:30, niemeyer wrote:
> Can we please call this as PathKey? That's really what it is. Its main
property
> is being unique among other entities and having no slashes so that we can use
it
> in a path without trouble. Anyone that wishes such properties can use it, no
> matter if it's dealing with the agent or not. We can document it as such as
> well.

Done.