Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6497097: [api] GoogleClient -> AbstractGoogleJsonClient; HttpMethod -> String (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by yanivi
Modified:
14 years, 1 month ago
Reviewers:
rmistry
Base URL:
https://google-api-java-client.googlecode.com/hg/
Visibility:
Public.

Description

[api] GoogleClient -> AbstractGoogleJsonClient; HttpMethod -> String; subscriptions 1.11 -> 1.12

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : add subscribe #

Total comments: 8

Patch Set 4 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2516 lines, -241 lines) Patch
M checkstyle.xml View 1 2 3 1 chunk +0 lines, -20 lines 0 comments Download
M google-api-client-android/.settings/org.eclipse.jdt.ui.prefs View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M google-api-client-appengine/.settings/org.eclipse.jdt.ui.prefs View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineSubscriptionStore.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/AppEngineWebHookDeliveryMethod.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/CachedAppEngineSubscriptionStore.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/subscriptions/package-info.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client-java6/.settings/org.eclipse.jdt.ui.prefs View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M google-api-client-servlet/.settings/org.eclipse.jdt.ui.prefs View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/AbstractWebHookServlet.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/JdoSubscriptionStore.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/WebHookDeliveryMethod.java View 2 chunks +4 lines, -4 lines 0 comments Download
M google-api-client-servlet/src/main/java/com/google/api/client/googleapis/extensions/servlet/subscriptions/package-info.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/.settings/org.eclipse.jdt.core.prefs View 1 2 3 8 chunks +39 lines, -1 line 0 comments Download
M google-api-client/.settings/org.eclipse.jdt.ui.prefs View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/AbstractGoogleClient.java View 1 2 3 1 chunk +679 lines, -0 lines 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/AbstractGoogleClientRequest.java View 1 2 3 1 chunk +389 lines, -0 lines 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/GoogleClientRequestInitializer.java View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/GoogleKeyInitializer.java View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/MethodOverride.java View 1 5 chunks +86 lines, -18 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/batch/MultipartMixedContent.java View 1 chunk +1 line, -1 line 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/json/AbstractGoogleJsonClient.java View 1 2 3 1 chunk +158 lines, -0 lines 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/json/AbstractGoogleJsonClientRequest.java View 1 2 3 1 chunk +111 lines, -0 lines 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/json/GoogleJsonClientRequestInitializer.java View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/media/MediaHttpUploader.java View 1 2 3 6 chunks +54 lines, -8 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/services/GoogleClient.java View 14 chunks +6 lines, -58 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/services/GoogleKeyInitializer.java View 1 chunk +3 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/services/package-info.java View 1 chunk +4 lines, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/ClientTokenGenerator.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/EventTypes.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/MemorySubscriptionStore.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/Notification.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/NotificationCallback.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/Subscription.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/SubscriptionHeaders.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/SubscriptionManager.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/SubscriptionStore.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/TypedNotification.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/TypedNotificationCallback.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/UnparsedNotification.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/json/JsonNotificationCallback.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/json/package-info.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/subscriptions/package-info.java View 1 chunk +1 line, -1 line 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/testing/MockGoogleClient.java View 1 2 3 1 chunk +144 lines, -0 lines 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/testing/MockGoogleClientRequest.java View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/MockGoogleJsonClient.java View 1 2 3 1 chunk +146 lines, -0 lines 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/MockGoogleJsonClientRequest.java View 1 2 3 1 chunk +52 lines, -0 lines 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/testing/json/package-info.java View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A google-api-client/src/main/java/com/google/api/client/googleapis/testing/package-info.java View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/testing/subscriptions/MockNotificationCallback.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/testing/subscriptions/package-info.java View 1 chunk +2 lines, -2 lines 0 comments Download
A google-api-client/src/test/java/com/google/api/client/googleapis/AbstractGoogleClientTest.java View 1 2 3 1 chunk +133 lines, -0 lines 0 comments Download
A google-api-client/src/test/java/com/google/api/client/googleapis/GoogleKeyInitializerTest.java View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/MethodOverrideTest.java View 1 1 chunk +31 lines, -21 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/GoogleIdTokenVerifierTest.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/batch/BatchRequestTest.java View 10 chunks +34 lines, -37 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/batch/MultipartMixedContentTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
A google-api-client/src/test/java/com/google/api/client/googleapis/json/AbstractGoogleJsonClientTest.java View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/json/GoogleJsonErrorTest.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/media/MediaHttpDownloaderTest.java View 1 chunk +1 line, -1 line 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/media/MediaHttpUploaderTest.java View 1 chunk +28 lines, -30 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/services/GoogleClientTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/services/GoogleKeyInitializerTest.java View 1 chunk +1 line, -0 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/subscriptions/SubscriptionManagerTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
yanivi
14 years, 1 month ago (2012-09-07 17:11:42 UTC) #1
rmistry
http://codereview.appspot.com/6497097/diff/9001/google-api-client/src/main/java/com/google/api/client/googleapis/AbstractGoogleClient.java File google-api-client/src/main/java/com/google/api/client/googleapis/AbstractGoogleClient.java (right): http://codereview.appspot.com/6497097/diff/9001/google-api-client/src/main/java/com/google/api/client/googleapis/AbstractGoogleClient.java#newcode2 google-api-client/src/main/java/com/google/api/client/googleapis/AbstractGoogleClient.java:2: * Copyright (c) 2012 Google Inc. Remove Copyright line ...
14 years, 1 month ago (2012-09-10 13:38:55 UTC) #2
yanivi
I made a few additional fixes, so please check the diffs. https://codereview.appspot.com/6497097/diff/9001/google-api-client/src/main/java/com/google/api/client/googleapis/AbstractGoogleClient.java File google-api-client/src/main/java/com/google/api/client/googleapis/AbstractGoogleClient.java (right): ...
14 years, 1 month ago (2012-09-10 17:02:26 UTC) #3
rmistry
14 years, 1 month ago (2012-09-10 18:12:03 UTC) #4 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b