Issue 6497072: juju status with openstack data omission

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6497072: juju status with openstack data omission

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by hazmat

Modified:
11 years, 7 months ago

Reviewers:
mp+122394, gz

Visibility:
Public.

Description

juju status with openstack data omission Running status on openstack providers doesn't show machine addresses in status (unit addresses are shown). This is due to an optimization in status which relies on provider.get_machines to return ip address information on machines in an env instead of fetching details per machine. The ostack provider was using an api which did not provide ip addresses when retrieving multiple servers. The fix is to out to a listing api that does. https://code.launchpad.net/~hazmat/juju/ostack-status/+merge/122394 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -11 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/providers/openstack/client.py	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	juju/providers/openstack/provider.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	juju/providers/openstack/tests/test_getmachines.py	View	6 chunks	+8 lines, -8 lines	0 comments	Download
M	juju/providers/openstack/tests/test_shutdown.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

11 years, 7 months ago (2012-09-03 11:02:41 UTC) #2

Code looks good.

Annoyingly this is from a specific change I made during development on to not
use details when listing all servers. Addresses are certainly not included in
what gets returned from canonistack currently though.

Getting a single server always gives full details, which was not clear
previously.

https://codereview.appspot.com/6497072/diff/1/juju/providers/openstack/client.py
File juju/providers/openstack/client.py (right):

https://codereview.appspot.com/6497072/diff/1/juju/providers/openstack/client...
juju/providers/openstack/client.py:370: # KT 2012-08-31: Works on canonistack,
hp.
Can just delete the get_server_details method, it confused me and confused you
as well. Plain get_server does the right thing.

Expand All Messages | Collapse All Messages