Issue 6497051: environs/cloudinit: ZooKeeper -> StateServer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6497051: environs/cloudinit: ZooKeeper -> StateServer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by dave

Modified:
11 years, 8 months ago

Reviewers:
mp+121755

Visibility:
Public.

Description

environs/cloudinit: ZooKeeper -> StateServer This proposal is part of a set to add support for deploying an environment on MongoDB in parallel with ZooKeeper. https://code.launchpad.net/~dave-cheney/juju-core/078-environs-cloudinit-add-mongo/+merge/121755 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : environs/cloudinit: ZooKeeper -> StateServer #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -16 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View	1	5 chunks	+8 lines, -7 lines	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View	1	6 chunks	+8 lines, -8 lines	0 comments	Download
M	environs/ec2/ec2.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6497051/diff/1/environs/cloudinit/cloudinit.go File environs/cloudinit/cloudinit.go (right): https://codereview.appspot.com/6497051/diff/1/environs/cloudinit/cloudinit.go#newcode31 environs/cloudinit/cloudinit.go:31: HasState bool s/HasState/StateServer/

11 years, 8 months ago (2012-08-29 20:01:10 UTC) #2

dave_cheney.net

11 years, 8 months ago (2012-08-29 22:22:39 UTC) #3

*** Submitted:

environs/cloudinit: ZooKeeper -> StateServer

This proposal is part of a set to add support for deploying
an environment on MongoDB in parallel with ZooKeeper.

R=niemeyer
CC=
https://codereview.appspot.com/6497051

Expand All Messages | Collapse All Messages