Issue 6496132: mstate: add services watcher

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6496132: mstate: add services watcher

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by aram

Modified:
11 years, 7 months ago

Reviewers:
mp+124749, niemeyer

Visibility:
Public.

Description

mstate: add services watcher https://code.launchpad.net/~aramh/juju-core/74-mstate-watchers-services-nwo/+merge/124749 (do not edit description out of merge proposal)

Patch Set 2 : mstate: add services watcher #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+324 lines, -6 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mstate/service.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	mstate/state.go	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	mstate/state_test.go	View		1 chunk	+177 lines, -0 lines	0 comments	Download
M	mstate/watcher.go	View	1	2 chunks	+135 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

Pleasantly equivalent. Just one suggestion, and LGTM. https://codereview.appspot.com/6496132/diff/1/mstate/watcher.go File mstate/watcher.go (right): https://codereview.appspot.com/6496132/diff/1/mstate/watcher.go#newcode287 mstate/watcher.go:287: svc := ...

11 years, 7 months ago (2012-09-17 17:42:52 UTC) #2

aram

11 years, 7 months ago (2012-09-17 17:52:07 UTC) #3

*** Submitted:

mstate: add services watcher

R=niemeyer
CC=
https://codereview.appspot.com/6496132

Expand All Messages | Collapse All Messages