Issue 6496120: add toolsDir param to RunHook

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6496120: add toolsDir param to RunHook

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by fwereade

Modified:
11 years, 7 months ago

Reviewers:
mp+124222

Visibility:
Public.

Description

add toolsDir param to RunHook I feel this is somewhat inelegant, but clear and simple, and the right step forward at this stage. I still have ideas floating around my mind for a hook.Runner, which I currently *expect* to replace HookContext.RunHook, but I don't want to go off into the weeds looking for the perfect solution when this one is trivial, and right here. https://code.launchpad.net/~fwereade/juju-core/run-hook-tools-dir/+merge/124222 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : add toolsDir param to RunHook #

Total comments: 1

Patch Set 3 : add toolsDir param to RunHook #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -47 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujuc/server/context.go	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	cmd/jujuc/server/context_test.go	View	1 2	4 chunks	+9 lines, -5 lines	0 comments	Download
M	cmd/jujud/unit_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	worker/uniter/tools.go	View	1	2 chunks	+4 lines, -7 lines	0 comments	Download
M	worker/uniter/tools_test.go	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	worker/uniter/uniter.go	View	1	6 chunks	+11 lines, -18 lines	0 comments	Download
M	worker/uniter/uniter_test.go	View	1 2	5 chunks	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

This is great, LGTM https://codereview.appspot.com/6496120/diff/3001/worker/uniter/tools_test.go File worker/uniter/tools_test.go (right): https://codereview.appspot.com/6496120/diff/3001/worker/uniter/tools_test.go#newcode45 worker/uniter/tools_test.go:45: err = uniter.EnsureJujucSymlinks(s.toolsDir) Looks good ...

11 years, 7 months ago (2012-09-13 19:22:30 UTC) #3

fwereade

11 years, 7 months ago (2012-09-13 20:37:40 UTC) #4

*** Submitted:

add toolsDir param to RunHook

I feel this is somewhat inelegant, but clear and simple, and the right step
forward at this stage. I still have ideas floating around my mind for a
hook.Runner, which I currently *expect* to replace HookContext.RunHook, but
I don't want to go off into the weeds looking for the perfect solution when
this one is trivial, and right here.

R=niemeyer
CC=
https://codereview.appspot.com/6496120

Expand All Messages | Collapse All Messages