Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(910)

Issue 6495068: mstate: changed EnvironConfig like in state (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by TheMue
Modified:
11 years, 8 months ago
Reviewers:
mp+122266
Visibility:
Public.

Description

mstate: changed EnvironConfig like in state EnvironConfig now returns environs/config.Config like in state, also a setter has been added. Only the watcher is missing. https://code.launchpad.net/~themue/juju-core/go-mstate-environconfig/+merge/122266 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : mstate: changed EnvironConfig like in state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -19 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mstate/state.go View 2 chunks +16 lines, -3 lines 0 comments Download
M mstate/state_test.go View 2 chunks +25 lines, -16 lines 0 comments Download

Messages

Total messages: 4
TheMue
Please take a look.
11 years, 8 months ago (2012-08-31 12:48:23 UTC) #1
aram
LGTM
11 years, 8 months ago (2012-09-04 11:58:48 UTC) #2
niemeyer
LGTM
11 years, 8 months ago (2012-09-04 14:13:57 UTC) #3
TheMue
11 years, 8 months ago (2012-09-04 16:24:50 UTC) #4
*** Submitted:

mstate: changed EnvironConfig like in state

EnvironConfig now returns environs/config.Config like
in state, also a setter has been added. Only the watcher
is missing.

R=aram, niemeyer
CC=
https://codereview.appspot.com/6495068
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b