Issue 6495054: environs: change BestTools so it does not choose later versions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6495054: environs: change BestTools so it does not choose later versions

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by rog

Modified:
11 years, 8 months ago

Reviewers:
mp+121902

Visibility:
Public.

Description

environs: change BestTools so it does not choose later versions As discussed on-line, when upgrading we want to choose the latest version with number <= the proposed version. https://code.launchpad.net/~rogpeppe/juju-core/040-modify-best-tools/+merge/121902 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: BestTools doesn't choose later versions #

Patch Set 3 : environs: change BestTools so it does not choose later versions #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -15 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/tools.go	View	3 chunks	+12 lines, -7 lines	0 comments	Download
M	environs/tools_test.go	View	9 chunks	+31 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

11 years, 8 months ago (2012-08-30 08:27:33 UTC) #3

*** Submitted:

environs: change BestTools so it does not choose later versions

As discussed on-line, when upgrading we want to
choose the latest version with number <= the proposed
version.

R=niemeyer
CC=
https://codereview.appspot.com/6495054

Expand All Messages | Collapse All Messages