Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1324)

Issue 6494136: environs/ec2: use different metadata version

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by rog
Modified:
11 years, 7 months ago
Reviewers:
mp+124396
Visibility:
Public.

Description

environs/ec2: use different metadata version Despite being advertised in the amazon documentation, 2012-06-01 is not available in us-east at least. Now we've chosen 2011-01-01 as hopefully being available everywhere. Maybe "latest" would be better, but who knows what guarantees are provided with that? https://code.launchpad.net/~rogpeppe/juju-core/063-fix-metadata-url-for-real/+merge/124396 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/ec2: use different metadata version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/ec2/ec2.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
11 years, 7 months ago (2012-09-14 11:50:54 UTC) #1
fwereade
LGTM again (and the service did advertise this version when I checked, so fingers crossed ...
11 years, 7 months ago (2012-09-14 11:52:20 UTC) #2
rog
11 years, 7 months ago (2012-09-14 11:53:04 UTC) #3
*** Submitted:

environs/ec2: use different metadata version

Despite being advertised in the amazon documentation, 2012-06-01
is not available in us-east at least. Now we've chosen 2011-01-01
as hopefully being available everywhere. Maybe "latest" would
be better, but who knows what guarantees are provided with
that?

R=fwereade
CC=
https://codereview.appspot.com/6494136
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b