Serialization for DirectWrite.

[bungeman, 2012-08-30 20:44:54]

Adds serialization to DirectWrite font host. This allows gm to run so we can
start having a bot.

[reed1, 2012-08-31 12:16:38]

looks good, but a couple of questions/suggestions.

https://codereview.appspot.com/6494061/diff/1/src/ports/SkFontHost_win_dw.cpp
File src/ports/SkFontHost_win_dw.cpp (right):

https://codereview.appspot.com/6494061/diff/1/src/ports/SkFontHost_win_dw.cpp...
src/ports/SkFontHost_win_dw.cpp:231: 
Can we use an enum instead of a bool for this? The call sites would be much
clearer.

https://codereview.appspot.com/6494061/diff/1/src/ports/SkFontHost_win_dw.cpp...
src/ports/SkFontHost_win_dw.cpp:859: if (face->fFromStream) {
Do we really need to copy the font into a stream, and then copy that stream into
the caller's stream?

[bungeman, 2012-08-31 14:56:53]

https://codereview.appspot.com/6494061/diff/1/src/ports/SkFontHost_win_dw.cpp
File src/ports/SkFontHost_win_dw.cpp (right):

https://codereview.appspot.com/6494061/diff/1/src/ports/SkFontHost_win_dw.cpp...
src/ports/SkFontHost_win_dw.cpp:231: 
On 2012/08/31 12:16:38, reed1 wrote:
> Can we use an enum instead of a bool for this? The call sites would be much
> clearer.

Removed, now just using the existence of fontFileLoader (as was the original
intent).

https://codereview.appspot.com/6494061/diff/1/src/ports/SkFontHost_win_dw.cpp...
src/ports/SkFontHost_win_dw.cpp:859: if (face->fFromStream) {
On 2012/08/31 12:16:38, reed1 wrote:
> Do we really need to copy the font into a stream, and then copy that stream
into
> the caller's stream?

The data wasn't being copied, but two extra objects were, the
IDWriteFontFileStream and the wrapper for it (for conversion to SkStream). We
have the original SkStream in any event, so we should just use that.

[bungeman, 2012-08-31 20:00:18]

Committed revision 5368.