Issue 6494061: Serialization for DirectWrite.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6494061: Serialization for DirectWrite. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by bungeman

Modified:
11 years, 7 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Faster means of doing the same. #

Patch Set 3 : Remove extra field. #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+276 lines, -224 lines)			Patch
	M	src/ports/SkFontHost_win_dw.cpp	View	1 2	8 chunks	+276 lines, -224 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bungeman

Adds serialization to DirectWrite font host. This allows gm to run so we can start ...

11 years, 8 months ago (2012-08-30 20:44:54 UTC) #1

reed1

looks good, but a couple of questions/suggestions. https://codereview.appspot.com/6494061/diff/1/src/ports/SkFontHost_win_dw.cpp File src/ports/SkFontHost_win_dw.cpp (right): https://codereview.appspot.com/6494061/diff/1/src/ports/SkFontHost_win_dw.cpp#newcode231 src/ports/SkFontHost_win_dw.cpp:231: Can we ...

11 years, 7 months ago (2012-08-31 12:16:38 UTC) #2

bungeman

https://codereview.appspot.com/6494061/diff/1/src/ports/SkFontHost_win_dw.cpp File src/ports/SkFontHost_win_dw.cpp (right): https://codereview.appspot.com/6494061/diff/1/src/ports/SkFontHost_win_dw.cpp#newcode231 src/ports/SkFontHost_win_dw.cpp:231: On 2012/08/31 12:16:38, reed1 wrote: > Can we use ...

11 years, 7 months ago (2012-08-31 14:56:53 UTC) #3

Committed revision 5368.

Expand All Messages | Collapse All Messages