mstate: implement agent tools methods

mstate: implement agent tools methods



https://code.launchpad.net/~rogpeppe/juju-core/067-mstate-tools/+merge/124637

(do not edit description out of merge proposal)

[rog, 2012-09-17 10:24:24]

Please take a look.

[aram, 2012-09-17 10:34:07]

LGTM

https://codereview.appspot.com/6493125/diff/1/mstate/machine.go
File mstate/machine.go (right):

https://codereview.appspot.com/6493125/diff/1/mstate/machine.go#newcode62
mstate/machine.go:62: Update: D{{"$set", D{{"tools", *t}}}},
Btw, t would also have worked fine, the API uses reflect and dereferences and
flattens everything anyway.

[rog, 2012-09-17 11:05:18]

Please take a look.

[niemeyer, 2012-09-17 12:36:06]

https://codereview.appspot.com/6493125/diff/6001/mstate/machine.go
File mstate/machine.go (right):

https://codereview.appspot.com/6493125/diff/6001/mstate/machine.go#newcode23
mstate/machine.go:23: Tools      Tools
Point to discuss live:

When's this created? Should this be a pointer with omitempty?

https://codereview.appspot.com/6493125/diff/6001/mstate/machine.go#newcode62
mstate/machine.go:62: Update: D{{"$set", D{{"tools", *t}}}},
s/*t/t/

https://codereview.appspot.com/6493125/diff/6001/mstate/unit.go
File mstate/unit.go (right):

https://codereview.appspot.com/6493125/diff/6001/mstate/unit.go#newcode80
mstate/unit.go:80: Tools          Tools
Same.

https://codereview.appspot.com/6493125/diff/6001/mstate/unit.go#newcode138
mstate/unit.go:138: Update: D{{"$set", D{{"tools", t}}}},
Same.

[rog, 2012-09-17 13:00:58]

Please take a look.

https://codereview.appspot.com/6493125/diff/6001/mstate/machine.go
File mstate/machine.go (right):

https://codereview.appspot.com/6493125/diff/6001/mstate/machine.go#newcode23
mstate/machine.go:23: Tools      Tools
On 2012/09/17 12:36:07, niemeyer wrote:
> Point to discuss live:
> 
> When's this created? Should this be a pointer with omitempty?

Done.

https://codereview.appspot.com/6493125/diff/6001/mstate/machine.go#newcode62
mstate/machine.go:62: Update: D{{"$set", D{{"tools", *t}}}},
On 2012/09/17 12:36:07, niemeyer wrote:
> s/*t/t/

Done.

https://codereview.appspot.com/6493125/diff/6001/mstate/unit.go
File mstate/unit.go (right):

https://codereview.appspot.com/6493125/diff/6001/mstate/unit.go#newcode80
mstate/unit.go:80: Tools          Tools
On 2012/09/17 12:36:07, niemeyer wrote:
> Same.

Done.

https://codereview.appspot.com/6493125/diff/6001/mstate/unit.go#newcode138
mstate/unit.go:138: Update: D{{"$set", D{{"tools", t}}}},
On 2012/09/17 12:36:07, niemeyer wrote:
> Same.

Done.

[niemeyer, 2012-09-17 13:02:06]

LGTM

[rog, 2012-09-17 13:02:46]

*** Submitted:

mstate: implement agent tools methods

R=aram, niemeyer
CC=
https://codereview.appspot.com/6493125