code review 6493123: cmd/ld: fix compilation when GOARCH != GOHOSTARCH

cmd/ld: fix compilation when GOARCH != GOHOSTARCH

[atom, 2012-09-15 08:04:47]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2012-09-15 10:13:02]

Thank you for fixing this. I believe this fix is correct, but haven't been able
to test it fully as I don't have the proper 386 pkgs on this laptop.

http://codereview.appspot.com/6493123/diff/1/src/pkg/runtime/runtime.h
File src/pkg/runtime/runtime.h (right):

http://codereview.appspot.com/6493123/diff/1/src/pkg/runtime/runtime.h#newcod...
src/pkg/runtime/runtime.h:121: enum
If I understand the problem properly, the ld failure was due to a conflict over
the definition of PtrSize. If this was the cause, I think a comment here to warn
others of the implication of this value may be in order.

[dave_cheney.net, 2012-09-15 10:25:53]

libs installed, fix LGTM.

[atom, 2012-09-15 10:36:49]

https://codereview.appspot.com/6493123/diff/1/src/pkg/runtime/typekind.h
File src/pkg/runtime/typekind.h (right):

https://codereview.appspot.com/6493123/diff/1/src/pkg/runtime/typekind.h#newc...
src/pkg/runtime/typekind.h:36: CommonSize = 2*PtrSize + 6*PtrSize + 8,
This was the cause of the problem. src/pkg/runtime/typekind.h is included from
src/cmd/... which uses a value different from sizeof(void*) when crosscompiling.

Maybe typekind.h should contain a comment about this.

[dave_cheney.net, 2012-09-16 02:30:27]

https://codereview.appspot.com/6493123/diff/1/src/pkg/runtime/typekind.h
File src/pkg/runtime/typekind.h (right):

https://codereview.appspot.com/6493123/diff/1/src/pkg/runtime/typekind.h#newc...
src/pkg/runtime/typekind.h:36: CommonSize = 2*PtrSize + 6*PtrSize + 8,
On 2012/09/15 10:36:49, atom wrote:
> This was the cause of the problem. src/pkg/runtime/typekind.h is included from
> src/cmd/... which uses a value different from sizeof(void*) when
crosscompiling.

sounds like a great idea.
> 
> Maybe typekind.h should contain a comment about this.

[atom, 2012-09-16 05:13:11]

Hello rsc@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com),

Please take another look.

[minux1, 2012-09-16 18:58:26]

LGTM.

[rsc, 2012-09-17 20:44:06]

LGTM

That was subtle. Thanks!

[rsc, 2012-09-17 21:18:24]

*** Submitted as http://code.google.com/p/go/source/detail?r=f61169e934db ***

cmd/ld: fix compilation when GOARCH != GOHOSTARCH

R=rsc, dave, minux.ma
CC=golang-dev
http://codereview.appspot.com/6493123

Committer: Russ Cox <rsc@golang.org>