Issue 6493059: add charm.GitDir

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6493059: add charm.GitDir

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by fwereade

Modified:
11 years, 8 months ago

Reviewers:
mp+122043

Visibility:
Public.

Description

add charm.GitDir Hopefully uncontroversial; implementing this should help me focus on the actual charm.Manager implementation more easily. https://code.launchpad.net/~fwereade/juju-core/charm-git-dir/+merge/122043 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : add charm.GitDir #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+312 lines, -13 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	testing/http.go	View	1	4 chunks	+12 lines, -10 lines	0 comments	Download
A	worker/uniter/charm/git.go	View	1	1 chunk	+143 lines, -0 lines	0 comments	Download
A	worker/uniter/charm/git_test.go	View		1 chunk	+152 lines, -0 lines	0 comments	Download
M	worker/uniter/uniter_test.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

LGTM with one minor detail: https://codereview.appspot.com/6493059/diff/1/worker/uniter/charm/git.go File worker/uniter/charm/git.go (right): https://codereview.appspot.com/6493059/diff/1/worker/uniter/charm/git.go#newcode125 worker/uniter/charm/git.go:125: out, err := cmd.CombinedOutput() ...

11 years, 8 months ago (2012-08-30 12:08:08 UTC) #2

fwereade

11 years, 8 months ago (2012-08-30 14:32:28 UTC) #3

*** Submitted:

add charm.GitDir

Hopefully uncontroversial; implementing this should help me focus on the
actual charm.Manager implementation more easily.

R=niemeyer
CC=
https://codereview.appspot.com/6493059

Expand All Messages | Collapse All Messages