Issue 64930043: Log slow operations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 64930043: Log slow operations

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by haypo_gmail

Modified:
9 years, 10 months ago

Reviewers:
yselivanov

Visibility:
Public.

More Reviews

Description

Log slow operations

Patch Set 1 #

Patch Set 2 : Updated patch #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : _format_handle() uses isinstance #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -5 lines)			Patch
	M	asyncio/base_events.py	View	1 2 3	5 chunks	+27 lines, -5 lines	0 comments	Download
	M	tests/test_base_events.py	View	1 2 3	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

yselivanov

9 years, 10 months ago (2014-06-12 02:06:19 UTC) #1

https://codereview.appspot.com/64930043/diff/40001/asyncio/base_events.py
File asyncio/base_events.py (right):

https://codereview.appspot.com/64930043/diff/40001/asyncio/base_events.py#new...
asyncio/base_events.py:45: if func is tasks.Task._step or func is
tasks.Task._wakeup:
I think it's better to use __self__ for this:

     if isinstance(cb.__self__, tasks.Task): ...

https://codereview.appspot.com/64930043/diff/40001/asyncio/base_events.py#new...
asyncio/base_events.py:864: text = _format_handle(handle)
I'd suggest a different variable name -- maybe 'handle_repr' instead of 'text'?

Expand All Messages | Collapse All Messages