Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 6492105: code review 6492105: cmd/yacc: allow utf-8 token values (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by r
Modified:
9 years, 4 months ago
Reviewers:
CC:
golang-dev, rsc, 0xjnml
Visibility:
Public.

Description

cmd/yacc: allow utf-8 token values Also clean up the code and allow \U. Fixes issue 3007.

Patch Set 1 #

Patch Set 2 : diff -r e3fce06291ec https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -54 lines) Patch
M src/cmd/yacc/units.y View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/yacc/yacc.go View 4 chunks +61 lines, -51 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 4 months ago (2012-09-12 16:37:58 UTC) #1
rsc
LGTM That was fast.
9 years, 4 months ago (2012-09-12 16:41:04 UTC) #2
0xjnml
On 2012/09/12 16:41:04, rsc wrote: > LGTM No test(s)? -j
9 years, 4 months ago (2012-09-13 07:42:51 UTC) #3
r
9 years, 4 months ago (2012-09-13 20:59:03 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=0d32d96b4cc1 ***

cmd/yacc: allow utf-8 token values
Also clean up the code and allow \U.
Fixes issue 3007.

R=golang-dev, rsc, 0xjnml
CC=golang-dev
http://codereview.appspot.com/6492105
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b